[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r323630349 ## File path: src/operator/numpy/np_matrix_op-inl.h ## @@ -60,6 +60,81 @@ void NumpyTranspose(const nnvm::NodeAttrs& attrs,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r323630430 ## File path: src/operator/numpy/np_matrix_op-inl.h ## @@ -60,6 +60,81 @@ void NumpyTranspose(const nnvm::NodeAttrs& attrs,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r323629714 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -1744,6 +1744,66 @@ def test_indexing_mode(sampler, set_size,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r323629194 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -1744,6 +1744,66 @@ def test_indexing_mode(sampler, set_size,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r320589029 ## File path: src/operator/numpy/np_matrix_op-inl.h ## @@ -60,6 +60,82 @@ void NumpyTranspose(const nnvm::NodeAttrs& attrs,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r314200215 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -2331,6 +2331,72 @@ def test_math(): for op in ops:

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r314198909 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -829,6 +829,71 @@ def get_indices(axis_size):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r314198617 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -829,6 +829,71 @@ def get_indices(axis_size):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r314198515 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -829,6 +829,71 @@ def get_indices(axis_size):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15819: [Numpy]flip

haojin2 commented on a change in pull request #15819: [Numpy]flip URL: https://github.com/apache/incubator-mxnet/pull/15819#discussion_r314198274 ## File path: src/operator/numpy/np_flip_op.cc ## @@ -0,0 +1,67 @@ +/* Review comment: Move the code to the existing