[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-17 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575814068 @anjishnu Merged, thx for the contribution. This is an automated

[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-17 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575757199 @anjishnu it seems ok. I've re-triggered your failed website build, I think it's good for merge after that passes.

[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-16 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575348787 @anjishnu I'm only concerned about if there's any flakiness in such a test, to verify, please try `MXNET_TEST_COUNT=500 nosetests

[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-15 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574779763 @anjishnu I was actually only asking for getting the input data randomized with the original version of test code untouched.

[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-14 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574418897 @anjishnu Like this: https://github.com/apache/incubator-mxnet/pull/17298/files#diff-b129d416cc6980021cb35420a66e4d3aR334

[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-13 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574016263 @anjishnu Please address the sanity errors: