[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip

hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip URL: https://github.com/apache/incubator-mxnet/pull/17854#discussion_r394790380 ## File path: src/api/operator/numpy/random/np_choice_op.cc ## @@ -0,0 +1,91 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip

hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip URL: https://github.com/apache/incubator-mxnet/pull/17854#discussion_r394779496 ## File path: src/api/operator/tensor/matrix_op.cc ## @@ -0,0 +1,71 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip

hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip URL: https://github.com/apache/incubator-mxnet/pull/17854#discussion_r394778954 ## File path: src/api/operator/tensor/indexing_op.cc ## @@ -0,0 +1,78 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip

hzfan commented on a change in pull request #17854: [Numpy] FFI: random.choice, take and clip URL: https://github.com/apache/incubator-mxnet/pull/17854#discussion_r394778051 ## File path: python/mxnet/ndarray/numpy/_op.py ## @@ -680,13 +680,20 @@ def take(a, indices,