larroy commented on a change in pull request #16144: added
-DCMAKE_BUILD_TYPE=Release to docs for building from source
URL: https://github.com/apache/incubator-mxnet/pull/16144#discussion_r323459356
##########
File path: docs/install/build_from_source.md
##########
@@ -182,6 +182,8 @@ There is a configuration file for make,
**NOTE:** When certain set of build flags are set, MXNet archive increases to
more than 4 GB. Since MXNet uses archive internally archive runs into a bug
("File Truncated":
[bugreport](https://sourceware.org/bugzilla/show_bug.cgi?id=14625)) for
archives greater than 4 GB. Please use ar version 2.27 or greater to overcome
this bug. Please see https://github.com/apache/incubator-mxnet/issues/15084 for
more details.
+You can specify different cmake compiler configurations with the option
`CMAKE_BUILD_TYPE`. In most cases you should set this to option to `Release`
for a smaller and faster binary compared to `Debug`. Alternatively, if you are
interested in building the smallest binary you can set the option to
`MinSizeRel`. In the case you are developing MXNet you might choose `Debug`
instead.
+
Review comment:
Can you add relwithdebinfo for completeness?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
