[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17681: [CD] update pypi description, setup.py
leezu commented on a change in pull request #17681: [CD] update pypi
description, setup.py
URL: https://github.com/apache/incubator-mxnet/pull/17681#discussion_r389070401
##
File path: tools/pip/setup.py
##
@@ -27,7 +27,7 @@
if platform.system() == 'Linux':
sys.argv.append('--universal')
-sys.argv.append('--plat-name=manylinux1_x86_64')
+sys.argv.append('--plat-name=manylinux2010_x86_64')
Review comment:
```suggestion
sys.argv.append('--plat-name=manylinux2014_x86_64')
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17681: [CD] update pypi description, setup.py
leezu commented on a change in pull request #17681: [CD] update pypi
description, setup.py
URL: https://github.com/apache/incubator-mxnet/pull/17681#discussion_r389070274
##
File path: tools/pip/setup.py
##
@@ -27,7 +27,7 @@
if platform.system() == 'Linux':
sys.argv.append('--universal')
-sys.argv.append('--plat-name=manylinux1_x86_64')
+sys.argv.append('--plat-name=manylinux2010_x86_64')
Review comment:
Looking at the symbols in `libmxnet.so`, for `GLIBCXX` the highest version
used is `GLIBCXX_3.4.19 _ZNSt6chrono3_V212system_clock3nowEv` and for `GLIBC`
`GLIBC_2.16 __poll_chk`.
Those versions are not allowed in `manylinux2010`. However, they are allowed
in `manylinux2014`.
Reference: https://www.python.org/dev/peps/pep-0571/
https://www.python.org/dev/peps/pep-0599/
Until the CD is set up to build correctly for manylinux2010, I suggest to
change this line to 2014.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17681: [CD] update pypi description, setup.py
leezu commented on a change in pull request #17681: [CD] update pypi description, setup.py URL: https://github.com/apache/incubator-mxnet/pull/17681#discussion_r387208011 ## File path: tools/pip/doc/CPU_ADDITIONAL.md ## @@ -40,3 +40,11 @@ To install, use: ```bash pip install mxnet ``` + +Nightly Builds +-- +The nightly builds for this package can be found at: https://dist.mxnet.io/python/cpu +To install the latest nightly build, use: +```bash +pip install --pre mxnet -f https://dist.mxnet.io/python/cpu Review comment: Let's use https://dist.mxnet.io/python/all here to make it easier for users to install other variants of mxnet pip package ```suggestion pip install --pre mxnet -f https://dist.mxnet.io/python/all ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17681: [CD] update pypi description, setup.py
leezu commented on a change in pull request #17681: [CD] update pypi
description, setup.py
URL: https://github.com/apache/incubator-mxnet/pull/17681#discussion_r387207404
##
File path: tools/pip/setup.py
##
@@ -152,12 +159,12 @@ def has_ext_modules(self):
if variant.endswith('MKL'):
if platform.system() == 'Darwin':
shutil.copytree(os.path.join(CURRENT_DIR,
'mxnet-build/3rdparty/mkldnn/build/install/include'),
-os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn'))
+os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn'))
if platform.system() == 'Linux':
libdir, mxdir = os.path.dirname(LIB_PATH[0]), os.path.join(CURRENT_DIR,
'mxnet')
if os.path.exists(os.path.join(libdir, 'libgfortran.so.3')):
shutil.copy(os.path.join(libdir, 'libgfortran.so.3'), mxdir)
-package_data['mxnet'].append('mxnet/libgfortran.so.4')
+package_data['mxnet'].append('mxnet/libgfortran.so.3')
Review comment:
Good catch, thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
