[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #16537: Fix numpy bugs
reminisce commented on a change in pull request #16537: Fix numpy bugs URL: https://github.com/apache/incubator-mxnet/pull/16537#discussion_r336763825 ## File path: tests/python/unittest/test_symbol.py ## @@ -414,6 +416,47 @@ def test_gen_atomic_symbol_multiple_outputs(): bidirectional=True, state_outputs=True, mode='lstm') atomic_sym = s._gen_atomic_symbol() + +def test_load_save_symbol(): +batch_size = 10 +num_hdidden = 128 +num_features = 784 + +def get_net(): +data = mx.sym.var('data') +weight = mx.sym.var('weight', shape=(num_hdidden, 0)) +return mx.sym.FullyConnected(data, weight, num_hidden=num_hdidden) + +for flag1 in [False, True]: Review comment: I will rename them in another PR to save the CI cycle for this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #16537: Fix numpy bugs
reminisce commented on a change in pull request #16537: Fix numpy bugs URL: https://github.com/apache/incubator-mxnet/pull/16537#discussion_r336763763 ## File path: tests/python/unittest/test_symbol.py ## @@ -414,6 +416,47 @@ def test_gen_atomic_symbol_multiple_outputs(): bidirectional=True, state_outputs=True, mode='lstm') atomic_sym = s._gen_atomic_symbol() + +def test_load_save_symbol(): +batch_size = 10 +num_hdidden = 128 +num_features = 784 + +def get_net(): +data = mx.sym.var('data') +weight = mx.sym.var('weight', shape=(num_hdidden, 0)) +return mx.sym.FullyConnected(data, weight, num_hidden=num_hdidden) + +for flag1 in [False, True]: Review comment: I will rename them in another PR to save the CI cycle for this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #16537: Fix numpy bugs
reminisce commented on a change in pull request #16537: Fix numpy bugs URL: https://github.com/apache/incubator-mxnet/pull/16537#discussion_r336763763 ## File path: tests/python/unittest/test_symbol.py ## @@ -414,6 +416,47 @@ def test_gen_atomic_symbol_multiple_outputs(): bidirectional=True, state_outputs=True, mode='lstm') atomic_sym = s._gen_atomic_symbol() + +def test_load_save_symbol(): +batch_size = 10 +num_hdidden = 128 +num_features = 784 + +def get_net(): +data = mx.sym.var('data') +weight = mx.sym.var('weight', shape=(num_hdidden, 0)) +return mx.sym.FullyConnected(data, weight, num_hidden=num_hdidden) + +for flag1 in [False, True]: Review comment: I will rename them in another PR to save the CI cycle for this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services