[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-25 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r339259572 ## File path: src/operator/rnn-inl.h ## @@ -1360,15 +1360,16 @@ class RNNOp { // Create Dropout descriptors

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-25 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r339257797 ## File path: src/operator/rnn-inl.h ## @@ -1360,15 +1360,16 @@ class RNNOp { // Create Dropout descriptors

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-25 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r339257797 ## File path: src/operator/rnn-inl.h ## @@ -1360,15 +1360,16 @@ class RNNOp { // Create Dropout descriptors

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-23 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r338382491 ## File path: tests/nightly/test_dropout.py ## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-22 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r337757607 ## File path: src/operator/nn/dropout-inl.h ## @@ -253,7 +253,19 @@ class DropoutOp { const

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-22 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r337635368 ## File path: tests/nightly/test_dropout.py ## @@ -0,0 +1,80 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-22 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r337635368 ## File path: tests/nightly/test_dropout.py ## @@ -0,0 +1,80 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-22 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r337628660 ## File path: tests/nightly/test_dropout.py ## @@ -0,0 +1,80 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-21 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r336958379 ## File path: src/operator/nn/dropout-inl.h ## @@ -253,7 +253,16 @@ class DropoutOp { const

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-21 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r336932559 ## File path: tests/nightly/test_dropout_with_seed.py ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-21 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r336884918 ## File path: src/operator/nn/dropout-inl.h ## @@ -253,7 +253,16 @@ class DropoutOp { const

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #16532: fix dropout gpu seed

2019-10-20 Thread GitBox
roywei commented on a change in pull request #16532: fix dropout gpu seed URL: https://github.com/apache/incubator-mxnet/pull/16532#discussion_r336821250 ## File path: src/operator/nn/dropout-inl.h ## @@ -262,7 +262,7 @@ class DropoutOp {