[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518434385 @marcoabreu I think we're in agreement here. We will be distributing some pre-built libraries in an S3 bucket as examples. We will provide

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518404947 @marcoabreu we added an example directory at: example/lib_api. Currently the test.py includes a test that uses the locally built library

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518393421 Thanks @marcoabreu for the catch. As we discussed offline, the problem is not with the feature in this PR but with how

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-03 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-517942331 @leleamol Can you please review again to see if the implementation of the dlclose matches what you were thinking? @anirudh2290