szha commented on a change in pull request #18797:
URL: https://github.com/apache/incubator-mxnet/pull/18797#discussion_r463170714
##########
File path: tools/pip/setup.py
##########
@@ -156,10 +156,9 @@ def skip_markdown_comments(md):
package_data = {'mxnet': [os.path.join('mxnet',
os.path.basename(LIB_PATH[0]))],
'dmlc_tracker': []}
-if variant.endswith('MKL'):
- if platform.system() == 'Darwin':
- shutil.copytree(os.path.join(CURRENT_DIR,
'mxnet-build/3rdparty/mkldnn/build/install/include'),
- os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn'))
+if variant != 'NATIVE':
+ shutil.copytree(os.path.join(CURRENT_DIR,
'mxnet-build/3rdparty/mkldnn/include'),
+ os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn'))
Review comment:
there's a flag in mxnet runtime library on whether mkldnn is enabled.
instead of relying on variant it will be more robust to switch to that as
condition instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
