[GitHub] [incubator-mxnet] szha commented on issue #16553: Fix for wrong reqs set after switching from training to inference
szha commented on issue #16553: Fix for wrong reqs set after switching from training to inference URL: https://github.com/apache/incubator-mxnet/pull/16553#issuecomment-544339535 sounds good to both This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] szha commented on issue #16553: Fix for wrong reqs set after switching from training to inference
szha commented on issue #16553: Fix for wrong reqs set after switching from training to inference URL: https://github.com/apache/incubator-mxnet/pull/16553#issuecomment-544334924 As follow-up: 1. ideally we should be able to test for this explicitly. given that we lack the utility for such testing, I want to avoid blocking this fix on this basis 2. the keys/magic strings should ideally be centralized, maybe in an enum. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
