[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2020-01-17 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-57078 @mxnet-label-bot update [ONNX, pr-awaiting-merge] This

[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2019-09-05 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-528660874 @zhreshold for review/merge This is an automated

[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2019-09-04 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-528070023 All review comments addressed. Awaiting further review comments or approval.

[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2019-08-30 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-526771995 Based on offline discussion with @Roshrini, making use of ONNX's "slice_end_out_of_bounds" test instead of writing a

[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2019-08-24 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-524580058 @Roshrini @anirudhacharya @zhreshold for review This is

[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2019-08-01 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-517504038 This PR is ready for review. [Awaiting confirmation from the user

[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2019-06-16 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-502477526 Working on the test. Will have an update soon. This is

[GitHub] [incubator-mxnet] vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends

2019-05-14 Thread GitBox
vandanavk commented on issue #14942: ONNX export: Slice op - Handle None value for ends URL: https://github.com/apache/incubator-mxnet/pull/14942#issuecomment-492342340 @mxnet-label-bot add [ONNX, pr-awaiting-review] This is