ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-623597733
@ChaiBapchya Thanks for reviewing! Updated the preview link, please see
http://ec2-54-191-240-239.us-west-2.compute.amazonaws.com/
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622654275
@mxnet-bot run ci [windows-gpu, unix-gpu]
This is an automated message from the Apache Git Service.
To
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622525419
@mxnet-bot run ci [windows-gpu]
This is an automated message from the Apache Git Service.
To respond
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622436754
@mxnet-bot run ci [windows-gpu]
This is an automated message from the Apache Git Service.
To respond
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622250705
@leezu Thank you very much for reviewing. Really a good point. Fixed mobile
incompatible issue by listening to click to toggle the dropdown contents.
Tested the fix on
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622234277
@mxnet-label-bot update [pr-awaiting-merge]
This is an automated message from the Apache Git Service.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622125787
@mxnet-bot run ci [windows-gpu]
This is an automated message from the Apache Git Service.
To respond
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622036580
@aaronmarkham Yes, tested on all main stream browser including Firefox,
Chrome, Safari and Edge, it works well. I think older IE should also be good,
because it is
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-621479628
@mxnet-bot run ci [windows-gpu]
This is an automated message from the Apache Git Service.
To
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-621333110
@connorgoggins Thank you for testing this! This is a good one. I fixed the
bug and made the dropdown content close after user clicking an option.
The preview is
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620993509
@connorgoggins Thank you for the feedback. Hover for sure gives a good ux,
not to mention the consistency. The only problem I was trying to avoid is not
to let the
11 matches
Mail list logo
