aaronmarkham commented on a change in pull request #9876: temporary fix to
update the verionsioning of 1.1.0 that is skipped du?
URL: https://github.com/apache/incubator-mxnet/pull/9876#discussion_r170399617
##########
File path: docs/build_version_doc/build_doc.sh
##########
@@ -49,12 +49,12 @@ then
fi
# Build new released tag
-if [ $latest_tag != ${tag_list[0]} ]
+if [ $latest_tag == ${tag_list[0]} ] # this is a temporary fix changed from !=
to == (SHOULD BE REMOVED LATER)
Review comment:
Some other things that happen later, you don't want to trigger. This will
create a v1.1.0 folder down the line, and we don't want that.
These lines probably should be commented out when you run it for v1.1.0:
https://github.com/thinksanky/incubator-mxnet/blob/a982b14c4424852ad524cb89440dd23252803c8e/docs/build_version_doc/build_doc.sh#L66-L69
Maybe keep the README line...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
