[GitHub] apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)

2018-12-06 Thread GitBox
apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only) URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-445008620 @marcoabreu The harm of leaving this boolean return type *in this PR* is that it will cause confusion to developers and

[GitHub] apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)

2018-12-05 Thread GitBox
apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only) URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-444753750 @DickJC123 Thanks for your detailed explanation about the operator selection logic. I like the way you used a boolean

[GitHub] apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)

2018-12-05 Thread GitBox
apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only) URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-444663652 @ptrendx It would be great if you can add in the PR description why we need this option. Thanks!

[GitHub] apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)

2018-12-04 Thread GitBox
apeforest commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only) URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-444385641 Adding @sandeep-krishnamurthy for review. This is an