[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-07 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-371105396 Ok, I'll make a new PR with an implementation complying to numpy. This is an

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370652954 @piiswrong The difference of this operator and numpy's shuffle is not the default axis. This performs a batch operation but numpy does not. For

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370652954 @piiswrong The difference of this operator and numpy's shuffle is not the default axis. This performs a batch operation but numpy does not. For

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370486626 @cjolivier01 `test_bmod` fails in `Python3: MKLDNN-CPU`

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370652954 @piiswrong The difference of this operator and numpy's shuffle is not the default axis. This performs a batch operation but numpy does not. For

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370486626 `test_bmod` fails in `Python3: MKLDNN-CPU`

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370372706 @cjolivier01 This operator uses the random number generator obtained through `ResourceRequest::kRandom`. So it shares the random number state

[GitHub] asitstands commented on issue #9991: Random shuffle implementation

2018-03-05 Thread GitBox
asitstands commented on issue #9991: Random shuffle implementation URL: https://github.com/apache/incubator-mxnet/pull/9991#issuecomment-370372706 @cjolivier01 This operator uses the random number generator obtained with `ResourceRequest::kRandom`. So it shares the random number state with