[GitHub] cjolivier01 commented on issue #8340: Fill optimizations

cjolivier01 commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-338444522 done This is an automated message from the Apache Git Service. To respond to the

[GitHub] cjolivier01 commented on issue #8340: Fill optimizations

cjolivier01 commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-338053030 Ok @szha and I spoke offline. I added the new operator _full to be used for ndarray.full() function. It is tested in test_ndarray.test_outputs()

[GitHub] cjolivier01 commented on issue #8340: Fill optimizations

cjolivier01 commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-338025849 'full' on the radar? that struct isn't used. if someone wants to use it, they can add it. I am not going to add an unused kernel.

[GitHub] cjolivier01 commented on issue #8340: Fill optimizations

cjolivier01 commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-338025849 'full' on the radar? that struct isn't used. if someone wants to use it, they can add it. I am not going to add an unused kernel.

[GitHub] cjolivier01 commented on issue #8340: Fill optimizations

cjolivier01 commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337758247 You can re-add it if you need it sometime, although it's better to use OpBase::SetToScalar or op_with_req (op_with_req

[GitHub] cjolivier01 commented on issue #8340: Fill optimizations

cjolivier01 commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337752595 There's more than one thing you could be referring to in this PR. There's a FillCompute() and a set_to template, which are somewhat independent.

[GitHub] cjolivier01 commented on issue #8340: Fill optimizations

cjolivier01 commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337746688 I don't understand your question. Which item are you referring to and what gives you that assumption?