cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-368379579
is direct usage of __cuda_toolset documented?
This is an automated message from the Apache
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-368378873
btw setting a double-underscore variable like __cuda_toolset at a top level
looks suspicious. I don?t know of any other cmake packages that require such a
thing.
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366033126
cmake doesn't use config.mk. config.mk is for the Makefile, and standard
makefiles are very dumb compared to cmake (ie dont supply a language and
mechanisms for
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366020161
The first time a user goes to build something, you can;t just throw errors
at him and refuse to build. This discourages use of mxnet. I don;t know how
many
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366020161
The first time a user goes to build something, you can't just throw errors
at him and refuse to build. This discourages use of mxnet. I don't know how
many
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366014736
Anyway, I think we should understand why the current version is problematic.
It works on my machine and in CI. It isn't ideal that version isn't
auto-detected.
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366014736
Anyway, I think we should understand why this is problematic. It works on my
machine and in CI. It isn't ideal that version isn't auto-detected. When it
is set
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366014736
Anyway, I think we should understand why this is problematic. It works on my
machine and in CI. It isn't ideal that version isn't auto-detected. When it
is set
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366014067
Ok, I wasn't aware that it said that
This is an automated message from the Apache Git Service.
To
cjolivier01 commented on issue #9798: fix cmake
URL: https://github.com/apache/incubator-mxnet/pull/9798#issuecomment-366012745
It was reviewed. There is no rule that someone has to click "Approve". Where
does it say that? In fact, it was determined that it doesn't have to have that
10 matches
Mail list logo
