[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace

2018-12-02 Thread GitBox
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443512132 Thanks @hellonico !! This is an

[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace

2018-12-01 Thread GitBox
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443467638 @hellonico I was able to change the base in the PR, but I think you will need to rebase your

[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace

2018-12-01 Thread GitBox
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443467475 @hellonico - Can you change the PR to be against master ? Right now it against 1.3.0 - thanks!

[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace

2018-12-01 Thread GitBox
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443444577 I kicked off the Jenkins CI again - when it passes this is good to merge.

[GitHub] gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace

2018-11-30 Thread GitBox
gigasquid commented on issue #13499: [MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace URL: https://github.com/apache/incubator-mxnet/pull/13499#issuecomment-443387755 Thanks @hellonico so much for your contribution!  I'll take a closer look tomorrow. Don't worry