[GitHub] haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling

2018-05-17 Thread GitBox
haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling URL: https://github.com/apache/incubator-mxnet/pull/10780#discussion_r189058395 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -769,140 +769,161 @@ def test_poolin

[GitHub] haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling

2018-05-17 Thread GitBox
haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling URL: https://github.com/apache/incubator-mxnet/pull/10780#discussion_r189051853 ## File path: src/operator/nn/pooling.cc ## @@ -92,6 +92,9 @@ static bool PoolingShape(const n

[GitHub] haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling

2018-05-10 Thread GitBox
haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling URL: https://github.com/apache/incubator-mxnet/pull/10780#discussion_r187409574 ## File path: src/operator/nn/pooling.cc ## @@ -344,11 +347,18 @@ Three pooling options are su

[GitHub] haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling

2018-05-09 Thread GitBox
haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling URL: https://github.com/apache/incubator-mxnet/pull/10780#discussion_r187247799 ## File path: src/operator/nn/pool_utils.h ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache

[GitHub] haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling

2018-05-08 Thread GitBox
haojin2 commented on a change in pull request #10780: [MXNET-375] Lp Pooling and Global Lp Pooling URL: https://github.com/apache/incubator-mxnet/pull/10780#discussion_r186846020 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -745,7 +745,7 @@ def test_pooling_wi