[GitHub] piiswrong commented on a change in pull request #9904: Improve workspace in convolution/deconvolution

2018-02-28 Thread GitBox 
piiswrong commented on a change in pull request #9904: Improve workspace in 
convolution/deconvolution
URL: https://github.com/apache/incubator-mxnet/pull/9904#discussion_r171340747
 
 

 ##
 File path: src/operator/convolution_v1-inl.h
 ##
 @@ -344,9 +348,7 @@ class ConvolutionV1Op : public Operator {
  shape_dstunit_[1],
  shape_dstunit_[2] * nstep_);
 index_t required_size = scol.Size() + sdst.Size();
-CHECK_GE(param_.workspace, required_size)
-  << "\nMinimum workspace size: " << required_size * sizeof(DType) << " 
Bytes\n"
-  << "Given: " << param_.workspace * sizeof(DType) << " Bytes";
+param_.workspace = required_size;
 
 Review comment:
   I mean why do you need to modify param_. workspace?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] piiswrong commented on a change in pull request #9904: Improve workspace in convolution/deconvolution

2018-02-27 Thread GitBox 
piiswrong commented on a change in pull request #9904: Improve workspace in 
convolution/deconvolution
URL: https://github.com/apache/incubator-mxnet/pull/9904#discussion_r171123906
 
 

 ##
 File path: src/operator/convolution_v1-inl.h
 ##
 @@ -344,9 +348,7 @@ class ConvolutionV1Op : public Operator {
  shape_dstunit_[1],
  shape_dstunit_[2] * nstep_);
 index_t required_size = scol.Size() + sdst.Size();
-CHECK_GE(param_.workspace, required_size)
-  << "\nMinimum workspace size: " << required_size * sizeof(DType) << " 
Bytes\n"
-  << "Given: " << param_.workspace * sizeof(DType) << " Bytes";
+param_.workspace = required_size;
 
 Review comment:
   do you actually need to change this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] piiswrong commented on a change in pull request #9904: Improve workspace in convolution/deconvolution

2018-02-27 Thread GitBox 
piiswrong commented on a change in pull request #9904: Improve workspace in 
convolution/deconvolution
URL: https://github.com/apache/incubator-mxnet/pull/9904#discussion_r171123906
 
 

 ##
 File path: src/operator/convolution_v1-inl.h
 ##
 @@ -344,9 +348,7 @@ class ConvolutionV1Op : public Operator {
  shape_dstunit_[1],
  shape_dstunit_[2] * nstep_);
 index_t required_size = scol.Size() + sdst.Size();
-CHECK_GE(param_.workspace, required_size)
-  << "\nMinimum workspace size: " << required_size * sizeof(DType) << " 
Bytes\n"
-  << "Given: " << param_.workspace * sizeof(DType) << " Bytes";
+param_.workspace = required_size;
 
 Review comment:
   do you actually need to optimize this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services