piiswrong commented on a change in pull request #9981: [fix issue#9976] The
assignment problem in NDArray
URL: https://github.com/apache/incubator-mxnet/pull/9981#discussion_r172040979
##########
File path: src/ndarray/ndarray.cc
##########
@@ -1128,7 +1128,7 @@ void CopyFromToImpl(const NDArray& from, const NDArray&
to,
}
void CopyFromTo(const NDArray& from, const NDArray& to, int priority) {
- if (from.var() == to.var()) {
+ if (from.var() == to.var() && from.byte_offset() == to.byte_offset()) {
Review comment:
should we also check for size? @reminisce
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
