[GitHub] reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays

2017-07-29 Thread git
reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays URL: https://github.com/apache/incubator-mxnet/pull/7244#discussion_r130232814 ## File path: src/operator/tensor/elemwise_unary_op.h ## @@ -105,6 +105,38 @@ void IdentityComputeRs

[GitHub] reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays

2017-07-29 Thread git
reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays URL: https://github.com/apache/incubator-mxnet/pull/7244#discussion_r130232807 ## File path: src/ndarray/ndarray_function.cc ## @@ -42,15 +43,18 @@ void ElementwiseSumRspImpl(cons

[GitHub] reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays

2017-07-29 Thread git
reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays URL: https://github.com/apache/incubator-mxnet/pull/7244#discussion_r130228436 ## File path: src/ndarray/ndarray_function.cc ## @@ -42,15 +43,18 @@ void ElementwiseSumRspImpl(cons

[GitHub] reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays

2017-07-29 Thread git
reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays URL: https://github.com/apache/incubator-mxnet/pull/7244#discussion_r130228405 ## File path: include/mxnet/ndarray.h ## @@ -199,6 +199,11 @@ class NDArray { return ptr_->aux_