[GitHub] samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value

2018-09-10 Thread GitBox
samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value URL: https://github.com/apache/incubator-mxnet/pull/12284#issuecomment-419973671 @anirudh2290 fixed syntax to match mxnet style (curly braces). This change is now ready for merging

[GitHub] samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value

2018-09-05 Thread GitBox
samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value URL: https://github.com/apache/incubator-mxnet/pull/12284#issuecomment-418813774 @anirudh2290 can you help review/merge? This

[GitHub] samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value

2018-08-22 Thread GitBox
samskalicky commented on issue #12284: [MXNET-853] Fix for smooth_l1 operator scalar default value URL: https://github.com/apache/incubator-mxnet/pull/12284#issuecomment-415225615 @haojin2 linting fixed @zhreshold Is catching the exception what we want to do? What should we do after