[GitHub] solin319 commented on a change in pull request #8373: distribute training in fp16

2018-02-13 Thread GitBox
solin319 commented on a change in pull request #8373: distribute training in fp16 URL: https://github.com/apache/incubator-mxnet/pull/8373#discussion_r168089512 ## File path: src/kvstore/kvstore_dist.h ## @@ -272,16 +282,35 @@ class KVStoreDist : public KVStoreLocal {

[GitHub] solin319 commented on a change in pull request #8373: distribute training in fp16

2018-02-13 Thread GitBox
solin319 commented on a change in pull request #8373: distribute training in fp16 URL: https://github.com/apache/incubator-mxnet/pull/8373#discussion_r168054096 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -378,25 +379,46 @@ class KVStoreDistServer { if

[GitHub] solin319 commented on a change in pull request #8373: distribute training in fp16

2018-02-13 Thread GitBox
solin319 commented on a change in pull request #8373: distribute training in fp16 URL: https://github.com/apache/incubator-mxnet/pull/8373#discussion_r168054096 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -378,25 +379,46 @@ class KVStoreDistServer { if

[GitHub] solin319 commented on a change in pull request #8373: distribute training in fp16

2017-11-02 Thread GitBox
solin319 commented on a change in pull request #8373: distribute training in fp16 URL: https://github.com/apache/incubator-mxnet/pull/8373#discussion_r148712461 ## File path: src/kvstore/kvstore_dist.h ## @@ -45,12 +45,14 @@ namespace kvstore { * it's the server node's

[GitHub] solin319 commented on a change in pull request #8373: distribute training in fp16

2017-11-02 Thread GitBox
solin319 commented on a change in pull request #8373: distribute training in fp16 URL: https://github.com/apache/incubator-mxnet/pull/8373#discussion_r148706041 ## File path: src/kvstore/kvstore_dist.h ## @@ -45,12 +45,14 @@ namespace kvstore { * it's the server node's

[GitHub] solin319 commented on a change in pull request #8373: distribute training in fp16

2017-10-22 Thread GitBox
solin319 commented on a change in pull request #8373: distribute training in fp16 URL: https://github.com/apache/incubator-mxnet/pull/8373#discussion_r146169550 ## File path: python/mxnet/kvstore_server.py ## @@ -72,12 +72,12 @@ def run(self): _ctrl_proto =