[GitHub] sxjscience commented on a change in pull request #7264: gluon conv rnns

2017-09-21 Thread git
sxjscience commented on a change in pull request #7264: gluon conv rnns URL: https://github.com/apache/incubator-mxnet/pull/7264#discussion_r140282753 ## File path: python/mxnet/gluon/contrib/rnn/conv_rnn_cell.py ## @@ -0,0 +1,971 @@ +# Licensed to the Apache Software Found

[GitHub] sxjscience commented on a change in pull request #7264: gluon conv rnns

2017-09-20 Thread git
sxjscience commented on a change in pull request #7264: gluon conv rnns URL: https://github.com/apache/incubator-mxnet/pull/7264#discussion_r140149823 ## File path: python/mxnet/gluon/contrib/rnn/conv_rnn_cell.py ## @@ -0,0 +1,971 @@ +# Licensed to the Apache Software Found

[GitHub] sxjscience commented on a change in pull request #7264: gluon conv rnns

2017-07-31 Thread git
sxjscience commented on a change in pull request #7264: gluon conv rnns URL: https://github.com/apache/incubator-mxnet/pull/7264#discussion_r130318613 ## File path: tests/python/unittest/test_gluon_rnn.py ## @@ -192,6 +196,59 @@ def test_rnn_cells(): net.add(gluon.rnn.

[GitHub] sxjscience commented on a change in pull request #7264: gluon conv rnns

2017-07-31 Thread git
sxjscience commented on a change in pull request #7264: gluon conv rnns URL: https://github.com/apache/incubator-mxnet/pull/7264#discussion_r130315604 ## File path: python/mxnet/gluon/rnn/rnn_cell.py ## @@ -777,3 +785,329 @@ def unroll(self, length, inputs, begin_state=None