szha closed pull request #9965: Fix R build crash in CI URL: https://github.com/apache/incubator-mxnet/pull/9965
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/R-package/DESCRIPTION b/R-package/DESCRIPTION index b22751a8db2..fdda200c5c4 100644 --- a/R-package/DESCRIPTION +++ b/R-package/DESCRIPTION @@ -15,7 +15,7 @@ BugReports: https://github.com/dmlc/mxnet/issues Imports: methods, Rcpp (>= 0.12.1), - DiagrammeR (>= 0.9.0), + DiagrammeR (>= 1.0.0), visNetwork (>= 1.0.3), data.table, jsonlite, diff --git a/R-package/R/viz.graph.R b/R-package/R/viz.graph.R index 49f978a2cd9..196f1da4d8b 100644 --- a/R-package/R/viz.graph.R +++ b/R-package/R/viz.graph.R @@ -8,7 +8,6 @@ #' @importFrom stringr str_trim #' @importFrom jsonlite fromJSON #' @importFrom DiagrammeR create_graph -#' @importFrom DiagrammeR set_global_graph_attrs #' @importFrom DiagrammeR add_global_graph_attrs #' @importFrom DiagrammeR create_node_df #' @importFrom DiagrammeR create_edge_df @@ -143,7 +142,7 @@ graph.viz <- function(symbol, shape=NULL, direction="TD", type="graph", graph.wi } graph<- create_graph(nodes_df = nodes_df_new, edges_df = edge_df_new, directed = TRUE) %>% - set_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% + add_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% add_global_graph_attrs("rankdir", value = direction, attr_type = "graph") if (type=="vis"){ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
