[GitHub] szha commented on issue #11213: [MXNET-533] MXNet-ONNX export

2018-06-28 Thread GitBox
szha commented on issue #11213: [MXNET-533] MXNet-ONNX export
URL: https://github.com/apache/incubator-mxnet/pull/11213#issuecomment-401200760
 
 
   @sandeep-krishnamurthy thanks for the efforts. Please respect "request 
changes" as vetos nonetheless and try and reach @zhreshold, especially given 
that you sit in the same office. Much appreciated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] szha commented on issue #11213: [MXNET-533] MXNet-ONNX export

2018-06-28 Thread GitBox
szha commented on issue #11213: [MXNET-533] MXNet-ONNX export
URL: https://github.com/apache/incubator-mxnet/pull/11213#issuecomment-401180635
 
 
   @zhreshold if this is a small issue to address then let's request a patch 
from the author. Could you create an issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] szha commented on issue #11213: [MXNET-533] MXNet-ONNX export

2018-06-28 Thread GitBox
szha commented on issue #11213: [MXNET-533] MXNet-ONNX export
URL: https://github.com/apache/incubator-mxnet/pull/11213#issuecomment-401147675
 
 
   @zhreshold could you take a look at this change again and see if your 
concerns are sufficiently addressed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] szha commented on issue #11213: [MXNET-533] MXNet-ONNX export

2018-06-28 Thread GitBox
szha commented on issue #11213: [MXNET-533] MXNet-ONNX export
URL: https://github.com/apache/incubator-mxnet/pull/11213#issuecomment-401147501
 
 
   @sandeep-krishnamurthy There are vetos in effect from @zhreshold. Per 
agreement among committers you are not supposed to merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services