szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-468993160
Added tests
This is an automated message from the Apache Git Service.
To respond to the
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-466530736
@reminisce good catch. I was relying on existing tests before adding the
inplace option but forgot to add tests for them afterwards.
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-464166096
I haven't finished this PR yet as I haven't got around to add the in-place
option.
This is
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-462511502
I plan on adding an `inplace` argument to these fluent methods to allow
users to specify whether in-place operation should be used.
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-461213906
The current implementation would break backward compatibility for in-place
update.
This is
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-460752374
@TaoLv Other language bindings don't seem to have the fluent methods for
reshaping NDArray.
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-460486819
@stephenrawls actually, autograd comes into play in pure imperative mode.
MXNet's autograd is trace based and does not support in-place operation such as
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-460086429
@stephenrawls
> This fix only effects the Python version when operating on ndarrays, not
users of the expand_dims operator.
Right. The reshape
szha commented on issue #14053: in-place reshape ops
URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-459990251
@ZhennanQin I didn't test that specifically based on the assumption that the
backend implementation should not cause existing APIs such as `NDArray.reshape`
