[GitHub] szha commented on issue #8340: Fill optimizations

2017-10-21 Thread GitBox
szha commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-338442944 The symbol-side can be updated to use the new op as well. The frontend definition that needs update is here:

[GitHub] szha commented on issue #8340: Fill optimizations

2017-10-18 Thread GitBox
szha commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337758666 As long as `full` is still on the radar it's fine. Would you make the change to properly support `full` in that PR then?

[GitHub] szha commented on issue #8340: Fill optimizations

2017-10-18 Thread GitBox
szha commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337758666 As long as `full` is still on the radar it's fine. This is an automated message from the Apache

[GitHub] szha commented on issue #8340: Fill optimizations

2017-10-18 Thread GitBox
szha commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337756930 Agreed. I'm basically asking to keep both `fill` and `set_to`. This is an automated message

[GitHub] szha commented on issue #8340: Fill optimizations

2017-10-18 Thread GitBox
szha commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337753653 There's an op in NDArray which can benefit from fill

[GitHub] szha commented on issue #8340: Fill optimizations

2017-10-18 Thread GitBox
szha commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337751362 Having the value to fill as the template parameter. This is an automated message from the

[GitHub] szha commented on issue #8340: Fill optimizations

2017-10-18 Thread GitBox
szha commented on issue #8340: Fill optimizations URL: https://github.com/apache/incubator-mxnet/pull/8340#issuecomment-337744079 Is it intended to only support fill for zero and one going forward? This is an automated