[GitHub] thirdwing commented on issue #7476: R-package RNN refactor

2017-09-18 Thread git
thirdwing commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-330396699 @jeremiedb Can you update with master branch? Let's see the CI test. This is an

[GitHub] thirdwing commented on issue #7476: R-package RNN refactor

2017-09-14 Thread git
thirdwing commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-329609354 @jeremiedb Looking forward to the blog post. This is an automated message from the

[GitHub] thirdwing commented on issue #7476: R-package RNN refactor

2017-09-14 Thread git
thirdwing commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-329608629 The CI test failed with one python testing. Not related to this PR. This is an

[GitHub] thirdwing commented on issue #7476: R-package RNN refactor

2017-08-30 Thread git
thirdwing commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-326076547 @jeremiedb Great work! I think this can be merged after some very minor tweaks: (1) you don' need any `mxnet:::`, since your code is part of

[GitHub] thirdwing commented on issue #7476: R-package RNN refactor

2017-08-24 Thread git
thirdwing commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-324727926 Sorry, a little busy after back to school. I will review this in the weekend. This is