[GitHub] toddsundsted edited a comment on issue #11398: Floating Point Exception after Array Creation

2018-06-28 Thread GitBox
toddsundsted edited a comment on issue #11398: Floating Point Exception after 
Array Creation
URL: 
https://github.com/apache/incubator-mxnet/issues/11398#issuecomment-400872858
 
 
   @frankfliu I have a proposed fix here: 
https://github.com/apache/incubator-mxnet/pull/11397
   
   this small change ensures that `random_uniform(..)` and similar behave 
consistently with other methods for `NDArray` creation, like `zeros(...)`. I 
would love a review and feedback on the proposal.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] toddsundsted edited a comment on issue #11398: Floating Point Exception after Array Creation

2018-06-27 Thread GitBox
toddsundsted edited a comment on issue #11398: Floating Point Exception after 
Array Creation
URL: 
https://github.com/apache/incubator-mxnet/issues/11398#issuecomment-400872858
 
 
   @frankfliu I have a proposed fix here: 
https://github.com/apache/incubator-mxnet/pull/11397
   
   this small change ensures that `random_uniform(..)` and similar behave 
consistently with other methods for `NDArray` creation, like `zeros(...)`. I 
would love a review and feedback on the proposal.
   
   one test timed out, but the other tests all passed. not sure how to restart 
the timed-out test.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services