[GitHub] wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP
wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP URL: https://github.com/apache/incubator-mxnet/pull/10242#issuecomment-392326302 @WalterMa Yes. If you replace cls_prob with cls_score in [this line](https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/proposal-inl.h#L160), the symbol parameter will change to cls_score. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP
wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP URL: https://github.com/apache/incubator-mxnet/pull/10242#issuecomment-384836993 @piiswrong Hi! The document shows that [the sym version](https://mxnet.incubator.apache.org/api/python/symbol/contrib.html?highlight=proposal#mxnet.symbol.contrib.Proposal) of Proposal OP uses **cls_score**. However, the sym version uses **cls_prob**, and the ndarray version uses **cls_score**. My PR has made them consistent to **cls_prob**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP
wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP URL: https://github.com/apache/incubator-mxnet/pull/10242#issuecomment-384836993 @piiswrong Hi! The document shows that [the sym version](https://mxnet.incubator.apache.org/api/python/symbol/contrib.html?highlight=proposal#mxnet.symbol.contrib.Proposal) of Proposal OP uses **cls_score**. However, the sym version uses **cls_prob**, and the ndarray version uses **cls_score**. My PR has made them consistent to *cls_prob*. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP
wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP URL: https://github.com/apache/incubator-mxnet/pull/10242#issuecomment-384836993 @piiswrong Hi! The document shows that [the sym version](https://mxnet.incubator.apache.org/api/python/symbol/contrib.html?highlight=proposal#mxnet.symbol.contrib.Proposal) of Proposal OP uses **cls_score**. However, [the Faster R-CNN example](https://github.com/apache/incubator-mxnet/blob/master/example/rcnn/rcnn/symbol/symbol_resnet.py#L193) uses **cls_prob**. If making them consistent by using the sym version(cls_score), the old example and other detection projects([Deformable-ConvNets](https://github.com/msracver/Deformable-ConvNets/blob/master/faster_rcnn/symbols/resnet_v1_101_rcnn.py#L741), [mx-rcnn](https://github.com/precedenceguo/mx-rcnn/blob/master/rcnn/symbol/symbol_resnet.py#L100)) will be an error of parameter. I think using `cls_prob` is better. [mxnet.ndarray.contrib.MultiBoxDetection](https://mxnet.incubator.apache.org/api/python/ndarray/contrib.html?highlight=multibox#mxnet.ndarray.contrib.MultiBoxDetection) uses `cls_prob` too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP
wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for
Proposal OP and Multi Proposal OP
URL: https://github.com/apache/incubator-mxnet/pull/10242#issuecomment-376360282
@piiswrong
Yes. I use the test case,
[code](https://gist.github.com/wkcn/8015feae59a63956884d1ef8b9fbb743)
If I replace `cls_score` with `cls_prob` in the code, it will raise the
error:
```
Traceback (most recent call last):
File "/home/wkcn/proj/testpy/testmxp.py", line 95, in
test(rpn_pre_nms_top_n, rpn_post_nms_top_n)
File "/home/wkcn/proj/testpy/testmxp.py", line 58, in test
rpn_min_size = rpn_min_size, output_score = True)
File "", line 82, in Proposal
File "/home/wkcn/proj/mxnet/python/mxnet/_ctypes/ndarray.py", line 92, in
_imperative_invoke
ctypes.byref(out_stypes)))
File "/home/wkcn/proj/mxnet/python/mxnet/base.py", line 149, in check_call
raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: Cannot find argument 'cls_prob', Possible Arguments:
```
But it's right to use `cls_prob` in mx.sym.contrib.Proposal in [the
code](https://github.com/apache/incubator-mxnet/blob/master/example/rcnn/rcnn/symbol/symbol_resnet.py#L193)
The reason is that the function `ListArguments()` in
[proposal-inl.h](https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/proposal-inl.h#L160)
returns `{"cls_prob", "bbox_pred", "im_info"}`, it's used in symbol.
However, `.add_argument("cls_score", "NDArray-or-Symbol", "Score of how
likely proposal is object.")` in
[proposal.cc](https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/proposal.cc#L462)
is used in ndarray.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP
wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP URL: https://github.com/apache/incubator-mxnet/pull/10242#issuecomment-376016959 @piiswrong Thank you! But I found a problem. When using `mx.nd.contrib.Proposal` or `mx.nd.contrib.MultiProposal`, the parameter name is `cls_score`. When using `mx.sym.contrib.Proposal` or `mx.sym.contrib.MultiProposal`, the parameter name is `cls_prob`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP
wkcn commented on issue #10242: [MXNET-137]fix parameters name inconsistent for Proposal OP and Multi Proposal OP URL: https://github.com/apache/incubator-mxnet/pull/10242#issuecomment-376016959 @piiswrong Thank you! But I found a problem. When using `mx.nd.Proposal` or `mx.nd.MultiProposal`, the parameter name is `cls_score`. When using `mx.sym.Proposal` or `mx.sym.MultiProposal`, the parameter name is `cls_prob`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
