[GitHub] xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters

2018-09-05 Thread GitBox
xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters URL: https://github.com/apache/incubator-mxnet/pull/10933#issuecomment-418614889 @lupesko Hi, can I close this pr first as this is just code refactor and low priority. Thanks!

[GitHub] xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters

2018-05-17 Thread GitBox
xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters URL: https://github.com/apache/incubator-mxnet/pull/10933#issuecomment-390092279 ok, i'll have a try. This is an automated message

[GitHub] xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters

2018-05-14 Thread GitBox
xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters URL: https://github.com/apache/incubator-mxnet/pull/10933#issuecomment-388745011 According to https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/convolution.cc#L359, the dilate