[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-22 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-391214697 Finally it passes the CI :) @piiswrong This is an automated message from the

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-22 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-391152600 I should have addressed most of the reviews. Please let me know if there are any further comments. Thanks! Related Gluon-CV PR https://github.

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-22 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-391152600 I should have addressed the comments. Please let me know if there are any further notes. Thanks --

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-17 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-390098221 Remove OMP in backward, due to no atomic add in cpu. This is an automated mess

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-389709407 @piiswrong @zhreshold I have added the unit tests. Please see the updates. Thanks! ---

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-389658263 @piiswrong @zhreshold Could you please review this PR for adapting ROI Aligh from Caffe2. Thanks!

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-389631589 The docs are generated here http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10852/9/api/python/ndarray/contrib.html?highlight=roi#