[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators

zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-415642640 @azai91 could you please review the code?

[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators

zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-412706348 thanks for providing the performance results.

[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators

zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-408488135 Please benchmark the performance with this modification to make sure there isn't performance regression.

[GitHub] zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators

zheng-da commented on issue #11664: Fall back when sparse arrays are passed to MKLDNN-enabled operators URL: https://github.com/apache/incubator-mxnet/pull/11664#issuecomment-404652395 I have the same comment. Why not call `MKLDNNStorageType`?