[GitHub] [mynewt-newt] utzig commented on issue #376: newt upgrade throws error

2020-02-13 Thread GitBox
utzig commented on issue #376: newt upgrade throws error URL: https://github.com/apache/mynewt-newt/issues/376#issuecomment-585959374 This was fixed some time ago, and will be available on next release. If you installed through the Ubuntu packages, you can try uninstalling the package,

[GitHub] [mynewt-nimble] bergzand commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585940341 I have 09b619b427df801774708bedbe0ebf79f900bfdf running on a device here connected to my phone with periodic BLE traffic between the two. I will

[GitHub] [mynewt-core] utzig commented on issue #2186: stm32: unify peripheral initialization

2020-02-13 Thread GitBox
utzig commented on issue #2186: stm32: unify peripheral initialization URL: https://github.com/apache/mynewt-core/pull/2186#issuecomment-585935188 @kasjer Ok, so this won't be an easy review! But I did test every HW driver on at least one BSP; also I did a fairly thorough review of all PIN

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2186: stm32: unify peripheral initialization

2020-02-13 Thread GitBox
apache-mynewt-bot removed a comment on issue #2186: stm32: unify peripheral initialization URL: https://github.com/apache/mynewt-core/pull/2186#issuecomment-585932938 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2186: stm32: unify peripheral initialization

2020-02-13 Thread GitBox
apache-mynewt-bot commented on issue #2186: stm32: unify peripheral initialization URL: https://github.com/apache/mynewt-core/pull/2186#issuecomment-585934725 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2186: [WIP] stm32: unify peripheral initialization

2020-02-13 Thread GitBox
apache-mynewt-bot commented on issue #2186: [WIP] stm32: unify peripheral initialization URL: https://github.com/apache/mynewt-core/pull/2186#issuecomment-585932938 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2186: [WIP] stm32: unify peripheral initialization

2020-02-13 Thread GitBox
apache-mynewt-bot removed a comment on issue #2186: [WIP] stm32: unify peripheral initialization URL: https://github.com/apache/mynewt-core/pull/2186#issuecomment-585847157 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-newt] Abhiroop opened a new issue #376: newt upgrade throws error

2020-02-13 Thread GitBox
Abhiroop opened a new issue #376: newt upgrade throws error URL: https://github.com/apache/mynewt-newt/issues/376 Running `newt upgrade -v` results in the following error: ``` Error: Error updating "mcuboot": error: The following untracked working tree files would be overwritten

[GitHub] [mynewt-nimble] haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r379009772 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -227,7 +228,7 @@

[GitHub] [mynewt-nimble] haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r379010681 ## File path: porting/npl/riot/src/npl_os_riot.c ## @@ -39,9 +39,9 @@ ble_npl_sem_pend(struct

[GitHub] [mynewt-nimble] bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378991247 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -259,7 +262,9 @@

[GitHub] [mynewt-nimble] bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378991170 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -100,7 +100,10 @@

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2186: [WIP] stm32: unify peripheral initialization

2020-02-13 Thread GitBox
apache-mynewt-bot removed a comment on issue #2186: [WIP] stm32: unify peripheral initialization URL: https://github.com/apache/mynewt-core/pull/2186#issuecomment-584705685 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2186: [WIP] stm32: unify peripheral initialization

2020-02-13 Thread GitBox
apache-mynewt-bot commented on issue #2186: [WIP] stm32: unify peripheral initialization URL: https://github.com/apache/mynewt-core/pull/2186#issuecomment-585847157 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378924605 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -100,7 +100,10 @@

[GitHub] [mynewt-nimble] haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378925566 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -259,7 +262,9 @@

[GitHub] [mynewt-nimble] haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378928080 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -100,7 +100,10 @@

[GitHub] [mynewt-nimble] bergzand commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585808617 > Nice, I am just looking into doing the needed adaptions in RIOT for step 2... Thanks! I think my code is fine, but somehow the

[GitHub] [mynewt-nimble] haukepetersen commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585779112 Nice, I am just looking into doing the needed adaptions in RIOT for step 2...

[GitHub] [mynewt-nimble] bergzand commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585770289 And I think I broke something related to the announcements, I'll look into it

[GitHub] [mynewt-nimble] bergzand edited a comment on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand edited a comment on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585742429 > 1. catch overflows using asserts in `ble_npl_time_delay()` and `ble_npl_eventq_get()` for now, so we can get this PR merged and benefit

[GitHub] [mynewt-nimble] bergzand commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585742429 > 1. catch overflows using asserts in `ble_npl_time_delay()` and `ble_npl_eventq_get()` for now, so we can get this PR merged and benefit

[GitHub] [mynewt-nimble] sjanc opened a new pull request #756: nimble/ll: Fix offset calculation in SyncInfo

2020-02-13 Thread GitBox
sjanc opened a new pull request #756: nimble/ll: Fix offset calculation in SyncInfo URL: https://github.com/apache/mynewt-nimble/pull/756 If advertising event is interleaved by current periodic event offset was calculated from that event, and not future event. This resulted in

[GitHub] [mynewt-nimble] haukepetersen commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585678575 > assuming Nimble doesn't require timeouts longer than 1.19 hours in regular operations. for normal operation I don't think so, but I

[GitHub] [mynewt-nimble] bergzand commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585667034 > One more: the overflow issues is also present in `ble_npl_time_delay()`. These should show up only when the time in milliseconds causes

[GitHub] [mynewt-nimble] bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378769934 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -100,7 +100,8 @@

[GitHub] [mynewt-nimble] haukepetersen commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585654161 One more: the overflow issues is also present in `ble_npl_time_delay()`. Thinking about his a little more, I think that we should

[GitHub] [mynewt-nimble] bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
bergzand commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378768599 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -100,7 +100,8 @@

[GitHub] [mynewt-nimble] haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on a change in pull request #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378759196 ## File path: porting/npl/riot/include/nimble/nimble_npl_os.h ## @@ -100,7 +100,8 @@

[GitHub] [mynewt-nimble] haukepetersen commented on issue #753: npl/riot: Improve timer glue code

2020-02-13 Thread GitBox
haukepetersen commented on issue #753: npl/riot: Improve timer glue code URL: https://github.com/apache/mynewt-nimble/pull/753#issuecomment-585638627 @bergzand yes, this is indeed interesting :-) Changes are valid and the code looks good to me, testing it as we speak.

[GitHub] [mynewt-nimble] haukepetersen opened a new pull request #755: npl/riot: disable SM in default configuration

2020-02-13 Thread GitBox
haukepetersen opened a new pull request #755: npl/riot: disable SM in default configuration URL: https://github.com/apache/mynewt-nimble/pull/755 This PR is a continuation of #508 and it disables the security manager in the default NimBLE configuration for RIOT. Besides saving

[GitHub] [mynewt-newt] utzig commented on issue #343: Mcuboot hack to prevent `newt upgrade` failure

2020-02-13 Thread GitBox
utzig commented on issue #343: Mcuboot hack to prevent `newt upgrade` failure URL: https://github.com/apache/mynewt-newt/pull/343#issuecomment-585624151 @Thilanka97 You should upgrade `newt` to a version that includes a "hack" to remove this directory, the issue is not related to the

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2192: Add generic API to retrieve provisioned data from BSP

2020-02-13 Thread GitBox
kasjer commented on a change in pull request #2192: Add generic API to retrieve provisioned data from BSP URL: https://github.com/apache/mynewt-core/pull/2192#discussion_r378695952 ## File path: hw/mcu/nordic/nrf52xxx/src/nrf52_hw_id.c ## @@ -46,7 +50,20 @@