[GitHub] [mynewt-core] nkaje commented on a change in pull request #2175: da1469x: add initial crypto driver

2020-03-12 Thread GitBox
nkaje commented on a change in pull request #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#discussion_r391991491 ## File path: hw/drivers/crypto/crypto_da1469x/src/crypto_da1469x.c ## @@ -0,0 +1,246 @@ +/* + * Licensed to

[GitHub] [mynewt-core] nkaje commented on issue #2175: da1469x: add initial crypto driver

2020-03-12 Thread GitBox
nkaje commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-598505545 Results with apps/crypto_test ``` === Test vectors === AES-128-ECB enc vector 0: ok, sz=16 vector 1: ok, sz=16

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2175: da1469x: add initial crypto driver

2020-03-12 Thread GitBox
apache-mynewt-bot removed a comment on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-596809055 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2175: da1469x: add initial crypto driver

2020-03-12 Thread GitBox
apache-mynewt-bot commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-598415853 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] utzig commented on issue #2175: da1469x: add initial crypto driver

2020-03-12 Thread GitBox
utzig commented on issue #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-598388555 This was updated with all findings by @nkaje (thanks a lot!); it now works correctly with `crypto_test` app but still have the limitation that the

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #772: Add CI style checking

2020-03-12 Thread GitBox
apache-mynewt-bot removed a comment on issue #772: Add CI style checking URL: https://github.com/apache/mynewt-nimble/pull/772#issuecomment-598248525 ## Style check summary ### Our coding style is

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #772: Add CI style checking

2020-03-12 Thread GitBox
apache-mynewt-bot commented on issue #772: Add CI style checking URL: https://github.com/apache/mynewt-nimble/pull/772#issuecomment-598273788 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2239: dialog_da1469x: enhance otp and serial loader tools.

2020-03-12 Thread GitBox
apache-mynewt-bot commented on issue #2239: dialog_da1469x: enhance otp and serial loader tools. URL: https://github.com/apache/mynewt-core/pull/2239#issuecomment-598256087 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #772: DNM - Style check

2020-03-12 Thread GitBox
apache-mynewt-bot commented on issue #772: DNM - Style check URL: https://github.com/apache/mynewt-nimble/pull/772#issuecomment-598248525 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] nkaje opened a new pull request #2239: Otp tool updates based on test dev

2020-03-12 Thread GitBox
nkaje opened a new pull request #2239: Otp tool updates based on test dev URL: https://github.com/apache/mynewt-core/pull/2239 This PR brings in enhancement updates to the OTP and Serial Loading Tools. This is an automated

[GitHub] [mynewt-mcumgr] utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598203289 > I honestly did not understand @de-nordic comment, but I believe you both know what you're doing! To be clear,

[GitHub] [mynewt-mcumgr] carlescufi commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
carlescufi commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598203050 Thanks! @utzig we are trying to consolidate tinycbor so that it's the same as in mynewt.

[mynewt-mcumgr] branch master updated: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git The following commit(s) were added to refs/heads/master by this push: new 98e8f32 ext: lib: mgmt: Enabling

[GitHub] [mynewt-mcumgr] utzig merged pull request #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
utzig merged pull request #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-mcumgr] utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598201979 > @utzig @sjanc can we merge this? I honestly did not understand @de-nordic comment, but I believe you both know

[GitHub] [mynewt-mcumgr] carlescufi commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
carlescufi commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598200772 @utzig @sjanc can we merge this? This is an

[GitHub] [mynewt-nimble] rymanluk opened a new pull request #773: nimble: [WIP] Eatt initial implementation

2020-03-12 Thread GitBox
rymanluk opened a new pull request #773: nimble: [WIP] Eatt initial implementation URL: https://github.com/apache/mynewt-nimble/pull/773 This is initial implementation and not yet completed. Idea is to hide EATT from the application, but instead allow to Host to choose bearer to use. Code

[GitHub] [mynewt-mcumgr] de-nordic commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
de-nordic commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598184371 > > > Is this dependent on the merge of

[mynewt-nimble] 02/03: nimble/l2cap: Fix hs locking on reconfigure request

2020-03-12 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit 7bc2227df870be557552c723df0b1ec1c0752809 Author: Łukasz Rymanowski AuthorDate: Wed Mar 11 20:48:36 2020 +0100

[mynewt-nimble] 01/03: nimble/l2cap: Fix possible memory leak

2020-03-12 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit f14bc9b6a045de1d023157a11526cd17ee9bf5b7 Author: Łukasz Rymanowski AuthorDate: Wed Feb 26 15:22:08 2020 +0100

[mynewt-nimble] 03/03: nimble/l2cap: Move proc initialization Without that identifier was incorrectly set to 0

2020-03-12 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit 56229549cf0cbd0819307936aa15075dc0abac64 Author: Łukasz Rymanowski AuthorDate: Wed Mar 11 20:49:25 2020 +0100

[GitHub] [mynewt-nimble] rymanluk merged pull request #769: nimble/host: Couple of fixes to l2cap coc

2020-03-12 Thread GitBox
rymanluk merged pull request #769: nimble/host: Couple of fixes to l2cap coc URL: https://github.com/apache/mynewt-nimble/pull/769 This is an automated message from the Apache Git Service. To respond to the message, please

[mynewt-nimble] branch master updated (11f16a0 -> 5622954)

2020-03-12 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from 11f16a0 nimble/host: Fix check for valid static random address new f14bc9b nimble/l2cap: Fix possible

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391598289 ## File path: apps/advertiser/src/main.c ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391575678 ## File path: apps/advertiser/src/main.c ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391572954 ## File path: apps/advertiser/src/main.c ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391574971 ## File path: apps/advertiser/src/main.c ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391575435 ## File path: apps/advertiser/src/main.c ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391572283 ## File path: apps/advertiser/.gitignore ## @@ -0,0 +1,33 @@ +# Review comment: this file is not needed, we have top

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391597957 ## File path: apps/advertiser/src/main.c ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771#discussion_r391572823 ## File path: apps/advertiser/src/main.c ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mynewt-nimble] utzig opened a new pull request #772: Style check

2020-03-12 Thread GitBox
utzig opened a new pull request #772: Style check URL: https://github.com/apache/mynewt-nimble/pull/772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [mynewt-mcumgr] utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598132547 Is this dependent on the merge of https://github.com/zephyrproject-rtos/tinycbor/pull/11 ?

[mynewt-core] branch master updated: sys/console: Add auto search to ram based history

2020-03-12 Thread jerzy
This is an automated email from the ASF dual-hosted git repository. jerzy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 7b8bc8d sys/console: Add auto search to

[GitHub] [mynewt-core] kasjer merged pull request #2234: sys/console: Add auto search to ram based history

2020-03-12 Thread GitBox
kasjer merged pull request #2234: sys/console: Add auto search to ram based history URL: https://github.com/apache/mynewt-core/pull/2234 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor

2020-03-12 Thread GitBox
de-nordic opened a new pull request #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor URL: https://github.com/apache/mynewt-mcumgr/pull/71 Changes needed due to overwrite of Zephyr fork of Tinycbor with mynewt-core version. Signed-off-by: Dominik Ermel

[GitHub] [mynewt-nimble] rymanluk commented on issue #770: apps/bttester: Add support for Enhanced L2CAP COC

2020-03-12 Thread GitBox
rymanluk commented on issue #770: apps/bttester: Add support for Enhanced L2CAP COC URL: https://github.com/apache/mynewt-nimble/pull/770#issuecomment-598099843 it is needed for auto-pts https://github.com/intel/auto-pts/pull/354/commits/46668fb37160a81bd450120e00914414f465e1dd

[GitHub] [mynewt-nimble] Reynevan94 opened a new pull request #771: Added advertiser to apps

2020-03-12 Thread GitBox
Reynevan94 opened a new pull request #771: Added advertiser to apps URL: https://github.com/apache/mynewt-nimble/pull/771 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #769: nimble/host: Couple of fixes to l2cap coc

2020-03-12 Thread GitBox
rymanluk commented on a change in pull request #769: nimble/host: Couple of fixes to l2cap coc URL: https://github.com/apache/mynewt-nimble/pull/769#discussion_r391506782 ## File path: nimble/host/src/ble_l2cap_sig.c ## @@ -744,7 +744,6 @@

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #769: nimble/host: Couple of fixes to l2cap coc

2020-03-12 Thread GitBox
sjanc commented on a change in pull request #769: nimble/host: Couple of fixes to l2cap coc URL: https://github.com/apache/mynewt-nimble/pull/769#discussion_r391502832 ## File path: nimble/host/src/ble_l2cap_sig.c ## @@ -744,7 +744,6 @@

[GitHub] [mynewt-nimble] Reynevan94 closed pull request #768: Added advertiser, scanner, peripheral and central to apps

2020-03-12 Thread GitBox
Reynevan94 closed pull request #768: Added advertiser, scanner, peripheral and central to apps URL: https://github.com/apache/mynewt-nimble/pull/768 This is an automated message from the Apache Git Service. To respond to