[GitHub] [mynewt-core] vrahane commented on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support

vrahane commented on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-670961427 @jipanienko Thanks for the in-depth review. Really appreciate it. This is an automated message from the

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support

vrahane commented on a change in pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#discussion_r467493171 ## File path: hw/mcu/nordic/nrf91xx/include/mcu/mcu.h ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support

apache-mynewt-bot removed a comment on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-670797910 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support

apache-mynewt-bot commented on pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#issuecomment-670961274 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] vrahane commented on a change in pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support

vrahane commented on a change in pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#discussion_r467493121 ## File path: hw/mcu/nordic/nrf91xx/syscfg.yml ## @@ -0,0 +1,455 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [mynewt-core] jipanienko commented on a change in pull request #2348: Add NRF9160 BSP with I2C, SPI, UART and GPIO support

jipanienko commented on a change in pull request #2348: URL: https://github.com/apache/mynewt-core/pull/2348#discussion_r467489890 ## File path: hw/mcu/nordic/nrf91xx/syscfg.yml ## @@ -0,0 +1,455 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2351: PineTime SPI flash

apache-mynewt-bot removed a comment on pull request #2351: URL: https://github.com/apache/mynewt-core/pull/2351#issuecomment-670849441 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2351: PineTime SPI flash

apache-mynewt-bot commented on pull request #2351: URL: https://github.com/apache/mynewt-core/pull/2351#issuecomment-670853553 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2253: bsp/pinetime: Add bsp for PineTime smartwatch

caspermeijn commented on a change in pull request #2253: URL: https://github.com/apache/mynewt-core/pull/2253#discussion_r467421464 ## File path: hw/bsp/pinetime/bsp.yml ## @@ -0,0 +1,62 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [mynewt-core] caspermeijn commented on pull request #2350: docs: Add page for build-time hooks

caspermeijn commented on pull request #2350: URL: https://github.com/apache/mynewt-core/pull/2350#issuecomment-670849587 Looks good to me This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2351: PineTime SPI flash

apache-mynewt-bot commented on pull request #2351: URL: https://github.com/apache/mynewt-core/pull/2351#issuecomment-670849441 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] caspermeijn opened a new pull request #2351: PineTime SPI flash

caspermeijn opened a new pull request #2351: URL: https://github.com/apache/mynewt-core/pull/2351 Use spi flash for the second image. This makes it possible to double the size of the image. To be compatible with other community firmwares the bootloader size is increased. This