[GitHub] [mynewt-core] vrahane commented on pull request #2671: apps/sensors_test: Remove blinking tasks

2021-08-21 Thread GitBox
vrahane commented on pull request #2671: URL: https://github.com/apache/mynewt-core/pull/2671#issuecomment-903205152 Yes, that is correct. It was meant to be same as slinky so that other devs could pick it up quite easily. I do agree, reducing the memory usage does make sense. -- This

[GitHub] [mynewt-core] utzig merged pull request #2669: hw: bsp: frdm-k82f: update LED definitions

2021-08-21 Thread GitBox
utzig merged pull request #2669: URL: https://github.com/apache/mynewt-core/pull/2669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[mynewt-core] branch master updated: hw: bsp: frdm-k82f: update LED definitions

2021-08-21 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 38fedd9 hw: bsp: frdm-k82f: update LED

[GitHub] [mynewt-core] utzig commented on pull request #2671: apps/sensors_test: Remove blinking tasks

2021-08-21 Thread GitBox
utzig commented on pull request #2671: URL: https://github.com/apache/mynewt-core/pull/2671#issuecomment-903172119 Looks like it copied the blinking code from slinky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-core] kasjer opened a new pull request #2671: apps/sensors_test: Remove blinking tasks

2021-08-21 Thread GitBox
kasjer opened a new pull request #2671: URL: https://github.com/apache/mynewt-core/pull/2671 Application defined 2 tasks to blink 1 led. It also provided default pin (15) for led if BSP did not provide LED_BLINK_PIN definition. Amount of RAM used for tasks and stacks prevents

[GitHub] [mynewt-core] utzig commented on pull request #2670: hw: mcu: kinetis: add MCGIRCLK configuration

2021-08-21 Thread GitBox
utzig commented on pull request #2670: URL: https://github.com/apache/mynewt-core/pull/2670#issuecomment-903101938 > Original code used different settings for mcgConfig_BOARD_ > Now one settings (from syscfg) is used in all places maybe it is OK, I don't know. Yeah, you got a

[GitHub] [mynewt-core] utzig commented on a change in pull request #2669: hw: bsp: frdm-k82f: update LED definitions

2021-08-21 Thread GitBox
utzig commented on a change in pull request #2669: URL: https://github.com/apache/mynewt-core/pull/2669#discussion_r693341842 ## File path: hw/bsp/frdm-k82f/include/bsp/bsp.h ## @@ -33,7 +33,9 @@ extern uint8_t __DATA_ROM; #define LED_RED_PIN MCU_GPIO_PORTC(8)

[GitHub] [mynewt-core] utzig merged pull request #2668: apps: timtest: fix frequency in comments

2021-08-21 Thread GitBox
utzig merged pull request #2668: URL: https://github.com/apache/mynewt-core/pull/2668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[mynewt-core] branch master updated: apps: timtest: fix frequency in comments

2021-08-21 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 7961294 apps: timtest: fix frequency in

[GitHub] [mynewt-core] utzig commented on a change in pull request #2669: hw: bsp: frdm-k82f: add LED_2 definition

2021-08-21 Thread GitBox
utzig commented on a change in pull request #2669: URL: https://github.com/apache/mynewt-core/pull/2669#discussion_r693341029 ## File path: hw/bsp/frdm-k82f/include/bsp/bsp.h ## @@ -33,7 +33,9 @@ extern uint8_t __DATA_ROM; #define LED_RED_PIN MCU_GPIO_PORTC(8)

[GitHub] [mynewt-core] utzig commented on a change in pull request #2670: hw: mcu: kinetis: add MCGIRCLK configuration

2021-08-21 Thread GitBox
utzig commented on a change in pull request #2670: URL: https://github.com/apache/mynewt-core/pull/2670#discussion_r693340888 ## File path: hw/mcu/nxp/kinetis/syscfg.yml ## @@ -24,6 +24,17 @@ syscfg.defs: value: restriction: $notnull +

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2669: hw: bsp: frdm-k82f: add LED_2 definition

2021-08-21 Thread GitBox
kasjer commented on a change in pull request #2669: URL: https://github.com/apache/mynewt-core/pull/2669#discussion_r693335098 ## File path: hw/bsp/frdm-k82f/include/bsp/bsp.h ## @@ -33,7 +33,9 @@ extern uint8_t __DATA_ROM; #define LED_RED_PIN MCU_GPIO_PORTC(8)

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2670: hw: mcu: kinetis: add MCGIRCLK configuration

2021-08-21 Thread GitBox
kasjer commented on a change in pull request #2670: URL: https://github.com/apache/mynewt-core/pull/2670#discussion_r69068 ## File path: hw/mcu/nxp/kinetis/syscfg.yml ## @@ -24,6 +24,17 @@ syscfg.defs: value: restriction: $notnull +