[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2860: riscv: Fix build warning

2022-08-03 Thread GitBox
apache-mynewt-bot commented on PR #2860: URL: https://github.com/apache/mynewt-core/pull/2860#issuecomment-1204221174 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1313: tools/hci_throughput: Added tp tests over encrypted link

2022-08-03 Thread GitBox
jrotkiewicz opened a new pull request, #1313: URL: https://github.com/apache/mynewt-nimble/pull/1313 @sjanc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1312: nimble/phy/nrf: Fix possible MIC error

2022-08-03 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1312: URL: https://github.com/apache/mynewt-nimble/pull/1312 CCM may take longer to finish than our handling or rx isr end, so make sure that we wait for CCM before checking MIC status. -- This is an automated message from the Apache Git

[GitHub] [mynewt-core] kasjer opened a new pull request, #2860: riscv: Fix build warning

2022-08-03 Thread GitBox
kasjer opened a new pull request, #2860: URL: https://github.com/apache/mynewt-core/pull/2860 This eliminates following warning: /tmp/ccfBOXIv.s: Assembler messages: /tmp/ccfBOXIv.s:6: Warning: setting incorrect section attributes for .data.fe310_flash_transmit

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2859: tinyusb/synopsys: Add RHPORT1 configuration option

2022-08-03 Thread GitBox
apache-mynewt-bot commented on PR #2859: URL: https://github.com/apache/mynewt-core/pull/2859#issuecomment-1203694213 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] kasjer opened a new pull request, #2859: tinyusb/synopsys: Add RHPORT1 configuration option

2022-08-03 Thread GitBox
kasjer opened a new pull request, #2859: URL: https://github.com/apache/mynewt-core/pull/2859 Recent changes in TinyUSB headers require CFG_TUSB_RHPORT1_MODE to be present in synopsys based chips (STMF4, STMF7). It used to be defined in TinyUSB if not present. So far mynewt

[GitHub] [mynewt-core] kasjer merged pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-08-02 Thread GitBox
kasjer merged PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-08-02 Thread GitBox
kasjer commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1203517348 @StarGate01 thanks for contributions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-08-02 Thread GitBox
apache-mynewt-bot commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1203216662 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-newt] sjanc merged pull request #484: Don't default to shallow clone for 'new' command

2022-08-02 Thread GitBox
sjanc merged PR #484: URL: https://github.com/apache/mynewt-newt/pull/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-newt] sjanc opened a new pull request, #484: Don't default to shallow clone for 'new' command

2022-08-02 Thread GitBox
sjanc opened a new pull request, #484: URL: https://github.com/apache/mynewt-newt/pull/484 Release tag may no longer be on top of master branch and shallow copy would result if checkout fail. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1311: apps/bttester: add support for testing Periodic Advertising

2022-08-01 Thread GitBox
apache-mynewt-bot commented on PR #1311: URL: https://github.com/apache/mynewt-nimble/pull/1311#issuecomment-1201108115 ## Style check fail: Payload was too large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1311: apps/bttester: add support for testing Periodic Advertising

2022-08-01 Thread GitBox
apache-mynewt-bot commented on PR #1311: URL: https://github.com/apache/mynewt-nimble/pull/1311#issuecomment-1201100851 ## Style check fail: Payload was too large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1311: apps/bttester: add support for testing Periodic Advertising

2022-08-01 Thread GitBox
apache-mynewt-bot commented on PR #1311: URL: https://github.com/apache/mynewt-nimble/pull/1311#issuecomment-1201041769 ## Style check fail: Payload was too large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-core] StarGate01 commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-30 Thread GitBox
StarGate01 commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1200314471 @kasjer Thank you for the style comments; I have applied your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-30 Thread GitBox
apache-mynewt-bot commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1200313023 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] rinehaidvon opened a new issue, #1310: host/mesh Multi-thread call bt_mesh_model_send at the same time

2022-07-30 Thread GitBox
rinehaidvon opened a new issue, #1310: URL: https://github.com/apache/mynewt-nimble/issues/1310 when bt_mesh_model_send was called in two different thread. there are two msgs send in the same time. bt_mesh_model_send -> model_send -> bt_mesh_trans_send -> trans_encrypt in

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-29 Thread GitBox
apache-mynewt-bot commented on PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1199173904 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1309: nimble/ll: Fix privacy handling when connecting to a new device

2022-07-29 Thread GitBox
apache-mynewt-bot commented on PR #1309: URL: https://github.com/apache/mynewt-nimble/pull/1309#issuecomment-1199143777 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1309: nimble/ll: Fix privacy handling when connecting to a new device

2022-07-29 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1309: URL: https://github.com/apache/mynewt-nimble/pull/1309 Using LL Privacy to initiate a connection to a new device (i.e. use 0x02 or 0x03 as own address type, peer is using an RPA) requires host to add peer RPA and our IRK to resolving

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1297: nimble/ll: Fix continuation events handling

2022-07-28 Thread GitBox
andrzej-kaczmarek merged PR #1297: URL: https://github.com/apache/mynewt-nimble/pull/1297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc merged pull request #1304: apps/btshell: Add default own_addr_type check

2022-07-27 Thread GitBox
sjanc merged PR #1304: URL: https://github.com/apache/mynewt-nimble/pull/1304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc merged pull request #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox
sjanc merged PR #1308: URL: https://github.com/apache/mynewt-nimble/pull/1308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox
apache-mynewt-bot commented on PR #1308: URL: https://github.com/apache/mynewt-nimble/pull/1308#issuecomment-1196565644 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox
apache-mynewt-bot commented on PR #1308: URL: https://github.com/apache/mynewt-nimble/pull/1308#issuecomment-1196518012 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1304: apps/btshell: Add default own_addr_type check

2022-07-27 Thread GitBox
apache-mynewt-bot commented on PR #1304: URL: https://github.com/apache/mynewt-nimble/pull/1304#issuecomment-1196513945 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1308: host/sm: fix check in ble_sm_pair_req_rx

2022-07-27 Thread GitBox
KKopyscinski opened a new pull request, #1308: URL: https://github.com/apache/mynewt-nimble/pull/1308 If SC_ONLY is enabled fail pairing request if either keysize is to small OR SC is not supported by peer. Previously it was an AND, which means both conditions must be true to fail

[GitHub] [mynewt-nimble] sjanc merged pull request #1307: tools/hci_throughput: Custom transport option

2022-07-27 Thread GitBox
sjanc merged PR #1307: URL: https://github.com/apache/mynewt-nimble/pull/1307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1307: tools/hci_throughput: Custom transport option

2022-07-27 Thread GitBox
sjanc commented on code in PR #1307: URL: https://github.com/apache/mynewt-nimble/pull/1307#discussion_r930716867 ## tools/hci_throughput/transport_factory.py: ## @@ -18,15 +18,31 @@ # import hci_socket +import logging +import traceback +import sys class

[GitHub] [mynewt-nimble] alberk8 commented on issue #1306: Example of starting and stopping ble

2022-07-26 Thread GitBox
alberk8 commented on issue #1306: URL: https://github.com/apache/mynewt-nimble/issues/1306#issuecomment-1196241227 Can someone please take a look at this implementation, it looks like the deinit does not release the `TaskHandle_t host_task_h` [

[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox
rymanluk commented on code in PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r930146040 ## nimble/host/src/ble_l2cap_coc.c: ## @@ -67,9 +67,9 @@ ble_l2cap_coc_srv_alloc(void) int ble_l2cap_coc_create_server(uint16_t psm, uint16_t mtu, -

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1307: tools/hci_throughput: Custom transport option

2022-07-26 Thread GitBox
apache-mynewt-bot commented on PR #1307: URL: https://github.com/apache/mynewt-nimble/pull/1307#issuecomment-1195752370 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1307: tools/hci_throughput: Custom transport option

2022-07-26 Thread GitBox
jrotkiewicz opened a new pull request, #1307: URL: https://github.com/apache/mynewt-nimble/pull/1307 Added option to pass custom transport module. @sjanc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox
apache-mynewt-bot commented on PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1195381681 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] jrotkiewicz commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox
jrotkiewicz commented on code in PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r929781378 ## nimble/host/src/ble_l2cap_coc.c: ## @@ -257,17 +265,19 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan) rx->credits--; -if

[GitHub] [mynewt-nimble] jrotkiewicz commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-26 Thread GitBox
jrotkiewicz commented on code in PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r929781103 ## nimble/host/src/ble_l2cap_coc.c: ## @@ -582,7 +597,12 @@ ble_l2cap_coc_recv_ready(struct ble_l2cap_chan *chan, struct os_mbuf *sdu_rx) return

[GitHub] [mynewt-nimble] sjanc merged pull request #1300: apps/bttester: do not distribute CSRK

2022-07-26 Thread GitBox
sjanc merged PR #1300: URL: https://github.com/apache/mynewt-nimble/pull/1300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] alberk8 opened a new issue, #1306: Example of starting and stopping ble

2022-07-25 Thread GitBox
alberk8 opened a new issue, #1306: URL: https://github.com/apache/mynewt-nimble/issues/1306 Is there any example of ble server/peripheral where the ble is stated, broadcast for a duration eg 90 seconds, then disposed/shutdown ble. Wait for 5 minutes create start broadcast again in this

[GitHub] [mynewt-core] kasjer commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-25 Thread GitBox
kasjer commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1193666753 @StarGate01 maybe you could change your commit a little bit to be more consistent with mynewt style that requires opening brace `{` to be on the same line as `if`. Since new syscfg

[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-22 Thread GitBox
rymanluk commented on code in PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r927661215 ## nimble/host/src/ble_l2cap_coc.c: ## @@ -186,10 +189,12 @@ ble_l2cap_coc_rx_fn(struct ble_l2cap_chan *chan) rx = >coc_rx; BLE_HS_DBG_ASSERT(rx !=

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1303: apps/blehr: Fix blehr notify stopped incorrectly

2022-07-22 Thread GitBox
apache-mynewt-bot commented on PR #1303: URL: https://github.com/apache/mynewt-nimble/pull/1303#issuecomment-1192533907 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-22 Thread GitBox
apache-mynewt-bot commented on PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1192501851 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-22 Thread GitBox
apache-mynewt-bot commented on PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1192468699 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-mcumgr-cli] rlevano77 opened a new issue, #29: Image upload does not work over UDP - Zephyr smp_svr sample

2022-07-21 Thread GitBox
rlevano77 opened a new issue, #29: URL: https://github.com/apache/mynewt-mcumgr-cli/issues/29 I am trying to setup the zephyr samples/subsys/mgmt/mcumgr/smp_svr using UDP I am using Windows 11 and Golang v1.18.4 After I added mcuboot to my atsame54_xpro board. I built the smp_svr

[GitHub] [mynewt-core] kasjer commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-21 Thread GitBox
kasjer commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1191269201 Hi, I am out of office, idea is good so definitely I will support it, I have not seen the code, I will take a look next week. Thanks for your submittion. Jerzy czw.,

[GitHub] [mynewt-core] StarGate01 commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-21 Thread GitBox
StarGate01 commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1191185810 @kasjer Is this something you would consider merging? The feature would be opt-in. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [mynewt-nimble] Fanhang32 closed issue #1302: Do you have plan to support LE Audio?

2022-07-20 Thread GitBox
Fanhang32 closed issue #1302: Do you have plan to support LE Audio? URL: https://github.com/apache/mynewt-nimble/issues/1302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-nimble] m-gorecki opened a new pull request, #1304: apps/btshell: Add default own_addr_type check

2022-07-20 Thread GitBox
m-gorecki opened a new pull request, #1304: URL: https://github.com/apache/mynewt-nimble/pull/1304 On default the application has taken "public" as own address type. Now the application checks if public addres is available on the device and if not, on default it uses "random" as own addres

[GitHub] [mynewt-nimble] Fanhang32 opened a new pull request, #1303: apps/blehr: Fix blehr notify stopped incorrectly

2022-07-20 Thread GitBox
Fanhang32 opened a new pull request, #1303: URL: https://github.com/apache/mynewt-nimble/pull/1303 Don't stop blehr notity if other handles subscribed Signed-off-by: Fan Hang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-nimble] Fanhang32 opened a new issue, #1302: Do you have plan to support LE Audio?

2022-07-19 Thread GitBox
Fanhang32 opened a new issue, #1302: URL: https://github.com/apache/mynewt-nimble/issues/1302 Do you have plan to support LE Audio? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-nimble] novumdun opened a new issue, #1301: Is there any plan to support Bluetooth LE Audio?

2022-07-18 Thread GitBox
novumdun opened a new issue, #1301: URL: https://github.com/apache/mynewt-nimble/issues/1301 Nimble is very lovely to use but does not support Bluetooth LE Audio. So is there any plan to support Bluetooth LE Audio? Thank you. -- This is an automated message from the Apache Git

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1300: apps/bttester: do not distribute CSRK

2022-07-18 Thread GitBox
apache-mynewt-bot commented on PR #1300: URL: https://github.com/apache/mynewt-nimble/pull/1300#issuecomment-1186923955 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1300: apps/bttester: do not distribute CSRK

2022-07-18 Thread GitBox
KKopyscinski opened a new pull request, #1300: URL: https://github.com/apache/mynewt-nimble/pull/1300 BLE_SM_OUR_KEY_DIST and BLE_SM_THEIR_KEY_DIST should be set to 3, as we do not support security mode 2 - CSRK shall not be distributed. -- This is an automated message from the Apache

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1299: porting/npl/nuttx: fix callout_handler implement

2022-07-15 Thread GitBox
apache-mynewt-bot commented on PR #1299: URL: https://github.com/apache/mynewt-nimble/pull/1299#issuecomment-1185259720 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] mkeydevelop opened a new pull request, #1299: porting/npl/nuttx: fix callout_handler implement

2022-07-15 Thread GitBox
mkeydevelop opened a new pull request, #1299: URL: https://github.com/apache/mynewt-nimble/pull/1299 callout_thread is working for all timeout callout, it need an endless loop to catch all message. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] AsafFisher opened a new issue, #1298: Library does not discover ANCS services.

2022-07-14 Thread GitBox
AsafFisher opened a new issue, #1298: URL: https://github.com/apache/mynewt-nimble/issues/1298 Using `ble_gattc_disc_all_svcs` will never show apple's ANCS services. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183854288 Yes, that sounds reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183559883 Checking SN in `ble_ll_conn_rx_isr_end` does only mean that previously txd PDU was acked, but the spec does not say anything about acking, it just states that a

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183554896 The spec does not say anything about acking, it just states that a valid non-empty PDU has to be txd/rxd: `has_nonempty_pdu` is updated in

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1297: nimble/ll: Fix continuation events handling

2022-07-13 Thread GitBox
apache-mynewt-bot commented on PR #1297: URL: https://github.com/apache/mynewt-nimble/pull/1297#issuecomment-1183440442 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183349582 @andrzej-kaczmarek I have some doubts that wether the `has_nonempty_pdu` should be set before or after the packet is acked. For me, I update the `last_data_pdu` in

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183325249 @sada45 I reworked continuation events handling a bit more, it should be easier to understand now and I believe it should now be handled properly. let me know how it

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1297: nimble/ll: Fix continuation events handling

2022-07-13 Thread GitBox
apache-mynewt-bot commented on PR #1297: URL: https://github.com/apache/mynewt-nimble/pull/1297#issuecomment-1183050539 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182959619 I am happy that helps! I take a look at the fix. I think there is one more bug. When checking the continuation number, it should ignore the connection events before the

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182943669 @sada45 good catch, thanks. I created a fix for both https://github.com/apache/mynewt-nimble/pull/1297. I still need to validate those more carefully since

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1297: nimble/ll: Fix continuation events handling

2022-07-13 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1297: URL: https://github.com/apache/mynewt-nimble/pull/1297 Continuation events shall be only applied if the next event is not a subrated event. Also the event counter shall be also updated only for events with non-empty PDUs received.

[GitHub] [mynewt-newtmgr] FARLY7 commented on issue #185: Flash alignment mismatch leads to large overhead with Zephyr mcumgr

2022-07-13 Thread GitBox
FARLY7 commented on issue #185: URL: https://github.com/apache/mynewt-newtmgr/issues/185#issuecomment-1182875958 +1 for the patch provided by @LockeKK. I was able to reduce the upload times down from 3.5mins to 44s: Original at 115,200 baud: `247.23 KiB / 247.23 KiB

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-12 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182782695 Besides, currentlly, the `connsm->last_pdu_event` will be updated once received a PDU no matter it is empty or not. However, this value should be only be updated if there is

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-12 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1181833269 I test the connection subrating but find the `Continuation Number` does not work. I think I find the reason. In the function `ble_ll_conn_next_event()` in `ble_ll_conn.c`,

[GitHub] [mynewt-newtmgr] sjanc merged pull request #191: nmp decode: allow registration of custom response handlers

2022-07-11 Thread GitBox
sjanc merged PR #191: URL: https://github.com/apache/mynewt-newtmgr/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1296: fixed bug of find cli with CONTAINER_OF() in bt_mesh_proxy_addr_add

2022-07-11 Thread GitBox
apache-mynewt-bot commented on PR #1296: URL: https://github.com/apache/mynewt-nimble/pull/1296#issuecomment-1180401261 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1296: fixed bug of find cli with CONTAINER_OF() in bt_mesh_proxy_addr_add

2022-07-11 Thread GitBox
apache-mynewt-bot commented on PR #1296: URL: https://github.com/apache/mynewt-nimble/pull/1296#issuecomment-1180102723 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] chinli opened a new pull request, #1296: fixed bug of find cli with CONTAINER_OF() in bt_mesh_proxy_addr_add

2022-07-11 Thread GitBox
chinli opened a new pull request, #1296: URL: https://github.com/apache/mynewt-nimble/pull/1296 the ptr of CONTAINER_OF() macro should be field position address of type, so, the buf parameter of bt_mesh_proxy_addr_add should be position address. -- This is an automated message from the

[GitHub] [mynewt-nimble] chinli closed pull request #1295: fixed bug of find cli with CONTAINER_OF() in bt_mesh_proxy_addr_add

2022-07-11 Thread GitBox
chinli closed pull request #1295: fixed bug of find cli with CONTAINER_OF() in bt_mesh_proxy_addr_add URL: https://github.com/apache/mynewt-nimble/pull/1295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [mynewt-nimble] chinli opened a new pull request, #1295: fixed bug of find cli with CONTAINER_OF() in bt_mesh_proxy_addr_add

2022-07-11 Thread GitBox
chinli opened a new pull request, #1295: URL: https://github.com/apache/mynewt-nimble/pull/1295 the ptr of CONTAINER_OF() macro should be field position address of type, so, the buf parameter of bt_mesh_proxy_addr_add should be position address. -- This is an automated message from the

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-09 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1179503065 Thanks for your reply! I'll just use the connection subrating with link-layer APIs for now. Here I found another question. If the BLE works in the noisy RF

[GitHub] [mynewt-nimble] novumdun opened a new issue, #1294: Func "nimble_port_init" has a err.

2022-07-06 Thread GitBox
novumdun opened a new issue, #1294: URL: https://github.com/apache/mynewt-nimble/issues/1294 ```c void nimble_port_init(void) { /* Initialize default event queue */ ble_npl_eventq_init(_eventq_dflt); /* Initialize the global memory pool */

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-06 Thread GitBox
apache-mynewt-bot commented on PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1176104776 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-07-06 Thread GitBox
apache-mynewt-bot commented on PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1176098876 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-newtmgr] niclas-ats commented on pull request #191: nmp decode: allow registration of custom response handlers

2022-07-06 Thread GitBox
niclas-ats commented on PR #191: URL: https://github.com/apache/mynewt-newtmgr/pull/191#issuecomment-1175880195 @all I'd like to get some feedback on this PR. Do I need to create an issue first and reference the pull request or did I miss to mention the maintainer? Thx in advance! --

[GitHub] [mynewt-nimble] sjanc merged pull request #1293: nimble/host/sm: rename remaining BLE_SM_SC_LVL to BLE_SM_LVL

2022-07-05 Thread GitBox
sjanc merged PR #1293: URL: https://github.com/apache/mynewt-nimble/pull/1293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-04 Thread GitBox
apache-mynewt-bot commented on PR #2858: URL: https://github.com/apache/mynewt-core/pull/2858#issuecomment-1174112940 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] StarGate01 opened a new pull request, #2858: hw/drivers/flash/spiflash: Add option to ignore JEDEC ID

2022-07-04 Thread GitBox
StarGate01 opened a new pull request, #2858: URL: https://github.com/apache/mynewt-core/pull/2858 This PR introduces three new **optional** configuration parameters: `SPIFLASH_IGNORE_MANUFACTURER`, `SPIFLASH_IGNORE_MEMORY_TYPE`, and `SPIFLASH_IGNORE_MEMORY_CAPACITY`. (Default: `0`).

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1293: nimble/host/sm: rename remaining BLE_SM_SC_LVL to BLE_SM_LVL

2022-07-04 Thread GitBox
apache-mynewt-bot commented on PR #1293: URL: https://github.com/apache/mynewt-nimble/pull/1293#issuecomment-1173855162 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sjanc merged pull request #1292: docs: Fix a few typos

2022-07-04 Thread GitBox
sjanc merged PR #1292: URL: https://github.com/apache/mynewt-nimble/pull/1292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] ujur007 opened a new issue, #2857: Is there a .pdf documentation for apache-mynewt?

2022-07-03 Thread GitBox
ujur007 opened a new issue, #2857: URL: https://github.com/apache/mynewt-core/issues/2857 I am working with Apache mynewt. It has quite good documentation but it is only online and moving from one tab to another is hectic. Do you know is there a pdf version for the documentation?

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1292: docs: Fix a few typos

2022-07-02 Thread GitBox
apache-mynewt-bot commented on PR #1292: URL: https://github.com/apache/mynewt-nimble/pull/1292#issuecomment-1172858191 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1292: docs: Fix a few typos

2022-07-02 Thread GitBox
apache-mynewt-bot commented on PR #1292: URL: https://github.com/apache/mynewt-nimble/pull/1292#issuecomment-1172856899 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] timgates42 opened a new pull request, #1292: docs: Fix a few typos

2022-07-02 Thread GitBox
timgates42 opened a new pull request, #1292: URL: https://github.com/apache/mynewt-nimble/pull/1292 There are small typos in: - apps/blehr/src/main.c - apps/ext_advertiser/src/main.c - nimble/controller/src/ble_ll.c - nimble/host/src/ble_att_svr.c -

[GitHub] [mynewt-nimble] kasjer merged pull request #1275: apps/blehci: Allow log/full implementation in syscfg

2022-07-01 Thread GitBox
kasjer merged PR #1275: URL: https://github.com/apache/mynewt-nimble/pull/1275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-mcumgr] sjanc merged pull request #162: cmd/img_mgmt: Fix compilation with dummy hash enabled

2022-07-01 Thread GitBox
sjanc merged PR #162: URL: https://github.com/apache/mynewt-mcumgr/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-newt] andrzej-kaczmarek merged pull request #483: mfg: Fix mfg app name

2022-06-30 Thread GitBox
andrzej-kaczmarek merged PR #483: URL: https://github.com/apache/mynewt-newt/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-newt] andrzej-kaczmarek opened a new pull request, #483: mfg: Fix mfg app name

2022-06-29 Thread GitBox
andrzej-kaczmarek opened a new pull request, #483: URL: https://github.com/apache/mynewt-newt/pull/483 This reverts commit 67de80e. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-newt] marcoNexion commented on pull request #440: mfg: account for updated bootloader path in mfg command

2022-06-29 Thread GitBox
marcoNexion commented on PR #440: URL: https://github.com/apache/mynewt-newt/pull/440#issuecomment-1169905020 Hi, after pulling this commit I've a compatibility issue. Since my own bootloader (a stub) is located in the bootloader area and not dependent of @mcuboot. Do I need to change

[GitHub] [mynewt-nimble] sjanc merged pull request #1252: Support for read and write suggested datalen cmds

2022-06-29 Thread GitBox
sjanc merged PR #1252: URL: https://github.com/apache/mynewt-nimble/pull/1252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc merged pull request #1288: Adjusting SC pairing

2022-06-29 Thread GitBox
sjanc merged PR #1288: URL: https://github.com/apache/mynewt-nimble/pull/1288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-newt] estutzenberger opened a new issue, #482: Issue with newt mfg create

2022-06-28 Thread GitBox
estutzenberger opened a new issue, #482: URL: https://github.com/apache/mynewt-newt/issues/482 I am having a similar issue to #439, but slightly different behavior. When I try to run the `mfg create` command, I get the following error: ```$ newt mfg create ble2 1.0.0 Error: failed to

[GitHub] [mynewt-core] sjanc merged pull request #2856: net/ip/native_socks: Fix build on with -Werror=stringop-overflow

2022-06-28 Thread GitBox
sjanc merged PR #2856: URL: https://github.com/apache/mynewt-core/pull/2856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2856: net/ip/native_socks: Fix build on with -Werror=stringop-overflow

2022-06-28 Thread GitBox
kasjer commented on code in PR #2856: URL: https://github.com/apache/mynewt-core/pull/2856#discussion_r908085008 ## net/ip/native_sockets/src/native_sock.c: ## @@ -196,7 +196,7 @@ native_sock_mn_addr_to_addr(struct mn_sockaddr *ms, struct sockaddr *sa, sun->sun_len =

[GitHub] [mynewt-core] kasjer merged pull request #2855: mcu/nrf5340: Trust zone RAM clean update

2022-06-28 Thread GitBox
kasjer merged PR #2855: URL: https://github.com/apache/mynewt-core/pull/2855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    4   5   6   7   8   9   10   11   12   13   >