utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-598616618
> Minor nit: CBC and CTR cases can be rearranged for better readability -
mask is 0, 2 and 3
Done!
utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-598388555
This was updated with all findings by @nkaje (thanks a lot!); it now works
correctly with `crypto_test` app but still have the limitation that the
utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-590942894
@agross-korg @nkaje What would be the best way to get this in? Does one of
you want to take over, or should I merge and fix after testing is done?
utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581932252
> one mutex to rule them...
:rofl: yeah, that is one approach, but the `crypto` driver's idea is to add
a lower layer that handles the HW
utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581547425
> @agross-korg @nkaje This would be incompatible with using the enc_flash
driver for da1469x at the same time; to test this you would need to use
utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581547071
@agross-korg @nkaje This would be incompatible with using the enc_flash
driver for da1469x at the same time; to test this you would need to use
utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581494641
> We need to make sure there aren't any other possible conflicts where
people are using the crypto driver somewhere else. I know we use the secure
utzig commented on issue #2175: da1469x: add initial crypto driver
URL: https://github.com/apache/mynewt-core/pull/2175#issuecomment-581180409
Fixed review issues; added the driver initialization to MCU code which I had
forgotten to do; fixed style issues.
