[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER

2021-04-15 Thread GitBox
vrahane commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820623728 @utzig done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER

2021-04-15 Thread GitBox
vrahane commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820616250 @utzig your are right, I did push to origin by mistake and then deleted it right after. The recent commits should fix that I guess. -- This is an automated message from

[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER

2021-04-14 Thread GitBox
vrahane commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-819464465 @andrzej-kaczmarek added a separate commit for the BUS driver changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER

2021-04-13 Thread GitBox
vrahane commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818753199 @andrzej-kaczmarek yes agreed, will add a separate commit for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER

2021-04-13 Thread GitBox
vrahane commented on pull request #2564: URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818752236 We can enable cache always but the problem with that is that sometimes the performance actually degrades instead of becoming better. It should be left to the developer to