ccollins476ad opened a new pull request #86: newt - Fix handling of private 
github repos.
URL: https://github.com/apache/mynewt-newt/pull/86
 
 
   The current handling of private github repos is broken in a few ways:
   
   1. Only used for retrieval of repository.yml; manual login+password entry 
required for cloning.
   2. Authentication tokens were handled incorrectly.  These should be handled 
just like passwords.
   
   This commit provides the following fixes:
   
   1. Use configured login and password for cloning as well as repository.yml 
retrieval.
   2. Remove 'token' configuration item ('password' works for tokens as well).
   3. Add 'password_env' configuration item.  This specifies the name of an 
environment variable containing the password for the private repo.  This 
setting is only used if 'password' is empty.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to