[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-09 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r232236907 ## File path: fs/fcb2/src/fcb_elem_info.c ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-09 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r232236580 ## File path: fs/fcb2/test/src/fcb_test.c ## @@ -46,6 +46,7 @@ struct flash_sector_range test_fcb_ranges[] = {

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-09 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r232235601 ## File path: fs/fcb2/src/fcb_append.c ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-09 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r232235677 ## File path: fs/fcb2/src/fcb_append.c ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-09 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r232235567 ## File path: fs/fcb2/src/fcb_area_info.c ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-09 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r232235501 ## File path: fs/fcb2/src/fcb_getnext.c ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-08 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r231851517 ## File path: fs/fcb2/src/fcb_append.c ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-08 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r231851486 ## File path: fs/fcb2/src/fcb_append.c ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-08 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r231851395 ## File path: fs/fcb2/include/fcb/fcb.h ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-08 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r231851307 ## File path: fs/fcb2/src/fcb.c ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-08 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r231851164 ## File path: sys/flash_map/include/flash_map/flash_map.h ## @@ -52,6 +52,15 @@ struct flash_area { uint32_t

[GitHub] kasjer commented on a change in pull request #1498: fcb2: second generation of fcb

2018-11-08 Thread GitBox
kasjer commented on a change in pull request #1498: fcb2: second generation of fcb URL: https://github.com/apache/mynewt-core/pull/1498#discussion_r231850607 ## File path: fs/fcb2/test/src/testcases/fcb_test_append.c ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache