mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-389130405
Solved on https://github.com/apache/mynewt-core/pull/1016
This is an automated message from the Apache
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-388184617
Ok, you are right. I will change it. (I was sure the GPIO HAL was uint8_t)
This is an automated message
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-388184617
Ok, you are right. I will change it.
This is an automated message from the Apache Git Service.
To respond
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-388098615
> But what you want here is not an IO pin, definitely not a GPIO pin, you
want a PWM pin. I'm not sure the comparison to GPIO is applicable here, this is
new ground.
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-388091863
@mlampert, so far we are doing soft PWM and hw PWM using GPIO pins, because
these are the only pins we got an abstraction which represents them (besides
the fact that
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-388091863
@mlampert, so far we are doing soft PWM and hw PWM using GPIO pins, because
these are the only pins we got an abstraction which represents them (besides
the fact that
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-388091863
@mlampert, so far we are doing soft PWM and hw PWM using GPIO pins, because
these are the only pins we got an abstraction which represents them (besides
the fact that
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-387910285
Note that on nordic devboards (namely nrf52840pdk) there are also multiple
ports containing multiple pins, we are still dealing with this by using some
addressing scheme
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-387705724
>Any chance I can persuade you to make pwm_chan_cfg::pin a uint32_t?
Ok, give me a use case where you'd need it. It is uint8_t because gpio hal
uses this data
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-387705724
>Any chance I can persuade you to make pwm_chan_cfg::pin a uint32_t?
Ok, give me a use case where you'd need it. It is uint8_t because gpio hal
uses this data
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-387705724
Ok, give me a use case where you'd need it. It is uint8_t because gpio hal
uses this data type, which makes sense to me since I doubt you'll have more
than 255 gpio
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-387586215
> The cycle and sequence have moved from the channel to the device. This
simplifies things quite a bit and makes a lot of sense for the cycle. I am
wondering though if
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-387499899
Hi Markus, the API and both drivers' refactors are ready for PR, I am
changing this on most BSP's right now.
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381991519
Ok, I agree with the most that have been said here but we need to take a
look at the nature of the problem and how PWM is implemented. Typically there's
a HW device
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189
Ok, I see 2 issues here, probably we want :
1 - To make pwm_disable to just stop the channel playback and not
unconfigure it. Sincelosing the device will make every
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189
Ok, I see 2 issues here, probably we want :
1 - To make pwm_disable to just stop the channel playback and not
unconfigure it. Sincelosing the device will make every
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189
Ok, I see 2 issues here, probably we want :
1 - To make pwm_disable to just stop the channel playback and not
unconfigure it.
2 - Closing the device will make every
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189
Ok, I see 2 issues here, probably we want :
1 - pwm_disable to just make the channel stop and not unconfigure it.
2 - Closing the device will make every channel
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-376981578
> An API for testing if the pwm is currently enabled would be useful.
I'm PRing this soon along with a README for pwm_test.
> The same goes for configured
mlaz commented on issue #955: pwm enabled?
URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-375739181
This seems reasonable to me. On it.
This is an automated message from the Apache Git Service.
To respond
20 matches
Mail list logo
