[mynewt-nimble] branch master updated: nimble/ll: Remove not needed NULL checks
This is an automated email from the ASF dual-hosted git repository.
janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
The following commit(s) were added to refs/heads/master by this push:
new daa8be8 nimble/ll: Remove not needed NULL checks
daa8be8 is described below
commit daa8be8a39a3913eea4bff0659df9181c44819d4
Author: Szymon Janc
AuthorDate: Mon Jan 20 10:12:19 2020 +0100
nimble/ll: Remove not needed NULL checks
ble_ll_scan_adv_decode_addr is always called with valid inita.
---
nimble/controller/src/ble_ll_scan.c | 12
1 file changed, 12 deletions(-)
diff --git a/nimble/controller/src/ble_ll_scan.c
b/nimble/controller/src/ble_ll_scan.c
index 26e7c07..2dd88e9 100644
--- a/nimble/controller/src/ble_ll_scan.c
+++ b/nimble/controller/src/ble_ll_scan.c
@@ -1877,10 +1877,6 @@ ble_ll_scan_get_addr_from_ext_adv(uint8_t *rxbuf, struct
ble_mbuf_hdr *ble_hdr,
has_adva = true;
}
-if (!inita) {
-goto done;
-}
-
if (ext_hdr_flags & (1 << BLE_LL_EXT_ADV_TARGETA_BIT)) {
*inita = ext_hdr + i;
*inita_type =
@@ -1905,10 +1901,6 @@ done:
}
}
-if (!inita) {
-return 0;
-}
-
if (aux_data->flags & BLE_LL_AUX_HAS_TARGETA) {
if (!has_inita) {
*inita = aux_data->targeta;
@@ -1942,10 +1934,6 @@ ble_ll_scan_adv_decode_addr(uint8_t pdu_type, uint8_t
*rxbuf,
*addr_type = ble_ll_get_addr_type(rxbuf[0] &
BLE_ADV_PDU_HDR_TXADD_MASK);
*addr = rxbuf + BLE_LL_PDU_HDR_LEN;
-if (!inita) {
-return 0;
-}
-
if (pdu_type != BLE_ADV_PDU_TYPE_ADV_DIRECT_IND) {
*inita = NULL;
*inita_type = 0;
[GitHub] [mynewt-nimble] sjanc merged pull request #734: nimble/ll: Remove not needed NULL checks
sjanc merged pull request #734: nimble/ll: Remove not needed NULL checks URL: https://github.com/apache/mynewt-nimble/pull/734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig opened a new pull request #2160: Fix more uncrustify issues
utzig opened a new pull request #2160: Fix more uncrustify issues URL: https://github.com/apache/mynewt-core/pull/2160 This brings the uncrustify config closer to matching the current style employed in Mynewt. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2160: Fix more uncrustify issues
apache-mynewt-bot commented on issue #2160: Fix more uncrustify issues
URL: https://github.com/apache/mynewt-core/pull/2160#issuecomment-576648273
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2160: Fix more uncrustify issues
apache-mynewt-bot commented on issue #2160: Fix more uncrustify issues
URL: https://github.com/apache/mynewt-core/pull/2160#issuecomment-576651039
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2160: Fix more uncrustify issues
apache-mynewt-bot removed a comment on issue #2160: Fix more uncrustify issues
URL: https://github.com/apache/mynewt-core/pull/2160#issuecomment-576648273
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[mynewt-core] branch master updated (259432f -> ac13b7e)
This is an automated email from the ASF dual-hosted git repository. utzig pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 259432f Add style checking to the CI add ac13b7e Fix more uncrustify issues No new revisions were added by this update. Summary of changes: uncrustify.cfg | 32 1 file changed, 16 insertions(+), 16 deletions(-)
[GitHub] [mynewt-core] utzig merged pull request #2160: Fix more uncrustify issues
utzig merged pull request #2160: Fix more uncrustify issues URL: https://github.com/apache/mynewt-core/pull/2160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2138: Add possibility to configure idle task stack size in syscfg.yml
utzig commented on issue #2138: Add possibility to configure idle task stack size in syscfg.yml URL: https://github.com/apache/mynewt-core/pull/2138#issuecomment-576655766 @brianwyld Please update your editor to use Unix line endings (`\n` only), instead of DOS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-mcumgr] branch master updated: Default CBORATTR_MAX_SIZE if CONFIG_MGMT_CBORATTR_MAX_SIZE is not defined.
This is an automated email from the ASF dual-hosted git repository. mlaz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git The following commit(s) were added to refs/heads/master by this push: new bae5b0c Default CBORATTR_MAX_SIZE if CONFIG_MGMT_CBORATTR_MAX_SIZE is not defined. new ca049eb Merge pull request #57 from mlaz/cborattr_max_default bae5b0c is described below commit bae5b0c581cf6e97baf092a9d2b69389fae6d8c9 Author: Miguel Azevedo AuthorDate: Mon Jan 20 18:26:37 2020 + Default CBORATTR_MAX_SIZE if CONFIG_MGMT_CBORATTR_MAX_SIZE is not defined. --- cborattr/src/cborattr.c | 4 1 file changed, 4 insertions(+) diff --git a/cborattr/src/cborattr.c b/cborattr/src/cborattr.c index e94a490..395c2ec 100644 --- a/cborattr/src/cborattr.c +++ b/cborattr/src/cborattr.c @@ -23,7 +23,11 @@ #ifdef __ZEPHYR__ #include +#ifdef CONFIG_MGMT_CBORATTR_MAX_SIZE #define CBORATTR_MAX_SIZE CONFIG_MGMT_CBORATTR_MAX_SIZE +#else +#define CBORATTR_MAX_SIZE 512 +#endif #endif #ifdef MYNEWT
[GitHub] [mynewt-mcumgr] mlaz merged pull request #57: Set CBORATTR_MAX_SIZE default when no Kconfig counterpart is defined.
mlaz merged pull request #57: Set CBORATTR_MAX_SIZE default when no Kconfig counterpart is defined. URL: https://github.com/apache/mynewt-mcumgr/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] sjanc opened a new pull request #735: nimble/ll: Fix HCI checks for periodic advertising
sjanc opened a new pull request #735: nimble/ll: Fix HCI checks for periodic advertising URL: https://github.com/apache/mynewt-nimble/pull/735 Core Specification 5.2 clarified HCI behavior for periodic advertising with regards to reconfiguring advertising instance and checking data length against periodic advertising interval. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and
preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576725550
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
+uint8_t count;
uint32_t *words;
};
@@ -152,12 +152,12 @@
static void
apply_preferred_pd_aon(void)
{
- if (get_reg32(0x50f8) == 0x8800) {
- set_reg32(0x50f8, 0x7700);
- }
- set_reg32_mask(0x5050, 0x1000, 0x1020);
- set_reg32(0x50a4, 0x00ca);
- set_reg32_mask(0x5064, 0x0003, 0x041e6ef4);
+if (get_reg32(0x50f8) == 0x8800) {
+set_reg32(0x50f8, 0x7700);
+}
+set_reg32_mask(0x5050, 0x1000, 0x1020);
+set_reg32(0x50a4, 0x00ca);
+set_reg32_mask(0x5064, 0x0003, 0x041e6ef4);
}
int
@@ -196,7 +196,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -242,7 +244,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] andrzej-kaczmarek opened a new pull request #2161: hw/mcu/dialog: Apply trim and preferred values
andrzej-kaczmarek opened a new pull request #2161: hw/mcu/dialog: Apply trim and preferred values URL: https://github.com/apache/mynewt-core/pull/2161 So far we assumed that 1st stage bootloader applied all trim values stored in CS and they are valid. However, since power domains can be disabled we need to make sure proper settings are reapplied once they are enabled. This patch automates this process: - read trim values for each applicable PD on init - apply trim values once PD is enabled (on 1st acquire) - apply preferred values on top of this This means that after waking up from extended sleep (where most of power domains are disabled) all settings are reapplied correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and
preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576729784
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,8 +31,8 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
-uint32_t *words;
+uint8_t count;
+uint32_t *words;
};
static const struct da1469x_pd_desc g_da1469x_pd_desc[] = {
@@ -196,7 +196,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -242,7 +244,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim
and preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576725550
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
+uint8_t count;
uint32_t *words;
};
@@ -152,12 +152,12 @@
static void
apply_preferred_pd_aon(void)
{
- if (get_reg32(0x50f8) == 0x8800) {
- set_reg32(0x50f8, 0x7700);
- }
- set_reg32_mask(0x5050, 0x1000, 0x1020);
- set_reg32(0x50a4, 0x00ca);
- set_reg32_mask(0x5064, 0x0003, 0x041e6ef4);
+if (get_reg32(0x50f8) == 0x8800) {
+set_reg32(0x50f8, 0x7700);
+}
+set_reg32_mask(0x5050, 0x1000, 0x1020);
+set_reg32(0x50a4, 0x00ca);
+set_reg32_mask(0x5064, 0x0003, 0x041e6ef4);
}
int
@@ -196,7 +196,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -242,7 +244,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2162: uncrustify: don't add braces to one-liner while
utzig commented on issue #2162: uncrustify: don't add braces to one-liner while URL: https://github.com/apache/mynewt-core/pull/2162#issuecomment-576753276 Fix the `while` issue seen in #2161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] utzig opened a new pull request #2162: uncrustify: don't add braces to one-liner while
utzig opened a new pull request #2162: uncrustify: don't add braces to one-liner while URL: https://github.com/apache/mynewt-core/pull/2162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim
and preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576729784
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,8 +31,8 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
-uint32_t *words;
+uint8_t count;
+uint32_t *words;
};
static const struct da1469x_pd_desc g_da1469x_pd_desc[] = {
@@ -196,7 +196,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -242,7 +244,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and
preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576755323
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
+uint8_t count;
uint32_t *words;
};
@@ -189,7 +189,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -235,7 +237,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2162: uncrustify: don't add braces to one-liner while
apache-mynewt-bot commented on issue #2162: uncrustify: don't add braces to
one-liner while
URL: https://github.com/apache/mynewt-core/pull/2162#issuecomment-576756739
## Style check summary
No suggestions at this time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] utzig merged pull request #2162: uncrustify: don't add braces to one-liner while
utzig merged pull request #2162: uncrustify: don't add braces to one-liner while URL: https://github.com/apache/mynewt-core/pull/2162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-core] branch master updated: uncrustify: don't add braces to one-liner while
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 32c3cc3 uncrustify: don't add braces to one-liner while 32c3cc3 is described below commit 32c3cc380a159f48c0c82156eba8a1b1547a7fe9 Author: Fabio Utzig AuthorDate: Tue Jan 21 13:05:57 2020 -0300 uncrustify: don't add braces to one-liner while Signed-off-by: Fabio Utzig --- uncrustify.cfg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/uncrustify.cfg b/uncrustify.cfg index e18023c..589b142 100644 --- a/uncrustify.cfg +++ b/uncrustify.cfg @@ -1057,7 +1057,7 @@ nl_cpp_lambda_leave_one_liners = false# false/true nl_if_leave_one_liners = false# false/true # Don't split one-line while statements - 'while(a) b++;' -nl_while_leave_one_liners = false# false/true +nl_while_leave_one_liners = true # false/true # Don't split one-line OC messages nl_oc_msg_leave_one_liner = false# false/true @@ -1669,7 +1669,7 @@ mod_full_brace_if_chain_only= false# false/true mod_full_brace_nl = 0# number # Add or remove braces on single-line 'while' statement -mod_full_brace_while= add # ignore/add/remove/force +mod_full_brace_while= ignore # ignore/add/remove/force # Add or remove braces on single-line 'using ()' statement mod_full_brace_using= ignore # ignore/add/remove/force
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim
and preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576755323
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
+uint8_t count;
uint32_t *words;
};
@@ -189,7 +189,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -235,7 +237,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and
preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576783387
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
+uint8_t count;
uint32_t *words;
};
@@ -189,7 +189,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -235,7 +237,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] utzig commented on issue #2161: hw/mcu/dialog: Apply trim and preferred values
utzig commented on issue #2161: hw/mcu/dialog: Apply trim and preferred values URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576785579 @andrzej-kaczmarek Please rebase on latest `master`! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-nimble] umer-ilyas opened a new issue #736: Issue in init and deInit of BLE and understanding of code
umer-ilyas opened a new issue #736: Issue in init and deInit of BLE and
understanding of code
URL: https://github.com/apache/mynewt-nimble/issues/736
sometimes i am having this problem after i call `nimble_port_stop();
nimble_port_deinit();`
`assertion "ret == pdPASS" failed: file
"F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/npl/freertos/src/npl_os_freertos.c",
line 291, function: npl_freertos_sem_release`
I am using esp-idfv3.3.1 with ESP32-WROOM
and tested with both nimble-1.1.0-idfv3.3 and nimble-1.2.0-idf
here is full assertion log
```
assertion "ret == pdPASS" failed: file
"F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/npl/freertos/src/npl_o
s_freertos.c", line 291, function: npl_freertos_sem_release
abort() was called at PC 0x4010fd17 on core 0
0x4010fd17: __assert_func at
/Users/ivan/e/newlib_xtensa-2.2.0-bin/newlib_xtensa-2.2.0/xtensa-esp32-elf/newlib/libc/stdlib/../../../.././newlib/libc/stdlib/assert.c:63
(discriminator 8)
ELF file SHA256:
a82d01ccf69a5c9f5068f08aad415292749fc0a546dfafccaf1963fd72c2cfba
Backtrace: 0x4008e978:0x3fff0c80 0x4008ebc5:0x3fff0ca0 0x4010fd17:0x3fff0cc0
0x4017db73:0x3fff0cf0 0x4017cd76:0x3fff0d20 0x4017590a:0x3fff0d40
0x40175922:0x3fff0d60 0x4017596e:0x3fff0d80 0x4017059e:0x3fff0da0
0x4017142c:0x3fff0dc0 0x40171454:0x3fff0e20 0x40176da2:0x3fff0
e80 0x40176dd2:0x3fff0eb0 0x40173d4d:0x3fff0ed0 0x4017cdce:0x3fff0ef0
0x40137ab8:0x3fff0f10 0x40097cc9:0x3fff0f30
0x4008e978: invoke_abort at
F:/msys32/home/umeri/esp/esp-idf/components/esp32/panic.c:715
0x4008ebc5: abort at
F:/msys32/home/umeri/esp/esp-idf/components/esp32/panic.c:715
0x4010fd17: __assert_func at
/Users/ivan/e/newlib_xtensa-2.2.0-bin/newlib_xtensa-2.2.0/xtensa-esp32-elf/newlib/libc/stdlib/../../../.././newlib/libc/stdlib/assert.c:63
(discriminator 8)
0x4017db73: npl_freertos_sem_release at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/npl/freertos/src/npl_os_freertos.c:369
0x4017cd76: ble_npl_sem_release at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/npl/freertos/include/nimble/nimble_npl_os.h:202
(inlined by) ble_hs_stop_cb at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/nimble/src/nimble_port.c:94
0x4017590a: ble_hs_stop_done at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_hs_stop.c:57
(discriminator 3)
0x40175922: ble_hs_stop_terminate_next_conn at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_hs_stop.c:75
0x4017596e: ble_hs_stop_gap_event at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_hs_stop.c:117
0x4017059e: ble_gap_event_listener_call at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_gap.c:1682
0x4017142c: ble_gap_conn_broken at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_gap.c:1682
0x40171454: ble_gap_rx_disconn_complete at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_gap.c:1682
0x40176da2: ble_hs_hci_evt_disconn_complete at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_hs_hci_evt.c:167
0x40176dd2: ble_hs_hci_evt_process at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/nimble/host/src/ble_hs_hci_evt.c:800
0x40173d4d: ble_hs_event_rx_hci_ev at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/npl/freertos/include/nimble/nimble_npl_os.h:109
0x4017cdce: ble_npl_event_run at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/npl/freertos/include/nimble/nimble_npl_os.h:121
(inlined by) nimble_port_run at
F:/msys32/home/umeri/esp/esp-idf/components/nimble/nimble/porting/nimble/src/nimble_port.c:81
0x40137ab8: bleprph_host_task at
F:/msys32/home/umeri/esp/cowlar-finger-print-scanner-esp32/components/iot-core/ble/app_ble.c:579
0x40097cc9: vPortTaskWrapper at
F:/msys32/home/umeri/esp/esp-idf/components/freertos/port.c:403
```
i have problem in understanding this part of code
this function never returns because of `SLIST_FOREACH ` keep calling the
listener callback function and i could not found a code which remove the
callback function from `slist`
```
/**
* Called when a stop procedure has completed.
*/
static void
ble_hs_stop_done(int status)
{
struct ble_hs_stop_listener_slist slist;
struct ble_hs_stop_listener *listener;
ble_hs_lock();
ble_gap_event_listener_unregister(_hs_stop_gap_listener);
slist = ble_hs_stop_listeners;
SLIST_INIT(_hs_stop_listeners);
ble_hs_enabled_state = BLE_HS_ENABLED_STATE_OFF;
ble_hs_unlock();
SLIST_FOREACH(listener, , link) {
listener->fn(status,
[GitHub] [mynewt-mcumgr] vrahane opened a new pull request #59: smp_svr: Change the stack size to 544
vrahane opened a new pull request #59: smp_svr: Change the stack size to 544 URL: https://github.com/apache/mynewt-mcumgr/pull/59 Based on the investigation we did, it seems the stack was overflowing by 96 bytes, so I am going to increase it by 76 bytes from the previous value which was 564. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-mcumgr] branch master updated: smp_svr: Change the stack size to whats needed (#59)
This is an automated email from the ASF dual-hosted git repository. vipulrahane pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git The following commit(s) were added to refs/heads/master by this push: new 66683c1 smp_svr: Change the stack size to whats needed (#59) 66683c1 is described below commit 66683c1df7a0fd5c99ea187359f0564d5076b375 Author: Vipul Rahane AuthorDate: Tue Jan 21 16:53:19 2020 -0800 smp_svr: Change the stack size to whats needed (#59) - 564 is enough for image upload to work --- samples/smp_svr/mynewt/syscfg.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/smp_svr/mynewt/syscfg.yml b/samples/smp_svr/mynewt/syscfg.yml index 2644ef5..cb435e0 100644 --- a/samples/smp_svr/mynewt/syscfg.yml +++ b/samples/smp_svr/mynewt/syscfg.yml @@ -36,7 +36,7 @@ syscfg.vals: CONFIG_MGMT: 1 # OS main/default task -OS_MAIN_STACK_SIZE: 1024 +OS_MAIN_STACK_SIZE: 564 # Lots of smaller mbufs are required for smp using typical BLE ATT MTU # values.
[GitHub] [mynewt-mcumgr] vrahane merged pull request #59: smp_svr: Change the stack size to 564
vrahane merged pull request #59: smp_svr: Change the stack size to 564 URL: https://github.com/apache/mynewt-mcumgr/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot commented on issue #2161: hw/mcu/dialog: Apply trim and
preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576864569
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
+uint8_t count;
uint32_t *words;
};
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim
and preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576783387
## Style check summary
hw/mcu/dialog/da1469x/src/da1469x_pd.c
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
-uint8_t count;
+uint8_t count;
uint32_t *words;
};
@@ -189,7 +189,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -235,7 +237,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
-while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+;
+}
ret = 1;
}
```
hw/mcu/dialog/da1469x/src/system_da1469x.c
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
-assert(CHIP_VERSION->CHIP_ID1_REG == '2');
-assert(CHIP_VERSION->CHIP_ID2_REG == '5');
-assert(CHIP_VERSION->CHIP_ID3_REG == '2');
-assert(CHIP_VERSION->CHIP_ID4_REG == '2');
-assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
-assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] pabigot opened a new pull request #58: cmd: img_mgmt: fix driver include path
pabigot opened a new pull request #58: cmd: img_mgmt: fix driver include path URL: https://github.com/apache/mynewt-mcumgr/pull/58 Zephyr will soon no longer add the drivers subdirectory of the include hierarchy to the search path, so references to driver headers must include the drivers/ prefix. Signed-off-by: Peter A. Bigot This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-mcumgr] utzig commented on issue #58: cmd: img_mgmt: fix driver include path
utzig commented on issue #58: cmd: img_mgmt: fix driver include path URL: https://github.com/apache/mynewt-mcumgr/pull/58#issuecomment-576869542 This is related to https://github.com/zephyrproject-rtos/zephyr/pull/21776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-mcumgr] utzig merged pull request #58: cmd: img_mgmt: fix driver include path
utzig merged pull request #58: cmd: img_mgmt: fix driver include path URL: https://github.com/apache/mynewt-mcumgr/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[mynewt-mcumgr] branch master updated: cmd: img_mgmt: fix driver include path
This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git The following commit(s) were added to refs/heads/master by this push: new ebe898c cmd: img_mgmt: fix driver include path ebe898c is described below commit ebe898ce545e186e3b375015447c36f6d79246ad Author: Peter A. Bigot AuthorDate: Fri Jan 17 12:53:12 2020 -0600 cmd: img_mgmt: fix driver include path Zephyr will soon no longer add the drivers subdirectory of the include hierarchy to the search path, so references to driver headers must include the drivers/ prefix. Signed-off-by: Peter A. Bigot --- cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c b/cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c index bb96f6f..af9abbb 100644 --- a/cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c +++ b/cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c @@ -23,7 +23,7 @@ LOG_MODULE_REGISTER(LOG_MODULE_NAME); #include -#include +#include #include #include #include
[GitHub] [mynewt-mcumgr] pabigot commented on issue #58: cmd: img_mgmt: fix driver include path
pabigot commented on issue #58: cmd: img_mgmt: fix driver include path URL: https://github.com/apache/mynewt-mcumgr/pull/58#issuecomment-576876281 @utzig Thanks for the fast response. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #365: [RFC] Simplify repo dependencies
ccollins476ad opened a new pull request #365: [RFC] Simplify repo dependencies
URL: https://github.com/apache/mynewt-newt/pull/365
This is a massive PR. I separated the work into a few different commits,
but reviewing this is still going to suck no matter how you slice it.
This PR concerns Mynewt's repo dependency system. That is to say, what
happens when a user runs `newt upgrade`. This functionality is burdened by two
unfortunate features:
1. The ability to depend on a *range* of repo versions, and
2. Mandatory `version.yml` files.
I propose that we greatly simplify repo management by removing both of these
features. Below I will describe each of these features and why I think they
should be removed. This PR implements the proposal.
BAD FEATURE 1: RANGED DEPENDENCIES
I'll start by giving some examples [1].
```
# Example 1
repository.apache-mynewt-core:
type: git
vers: '>=1.6.0'
url: g...@github.com:apache/mynewt-core.git
# Example 2 [2]
repository.apache-mynewt-nimble:
type: git
vers: '>=1.1.0 <=1.2.0'
url: g...@github.com:apache/mynewt-nimble.git
```
Each dependency uses comparison operators to express a range of acceptable
versions.
Now let me explain why I think ranged dependencies is a bad feature. To
begin with, a ranged dependency like `>=1.0.0 <2.0.0` only works if the repo
follows the SemVer model (or something like it). SemVer requires that the
major version number be bumped whenever a compability-breaking change is made
to the interface. If a repo doesn't faithfully follow SemVer, then there's no
guarantee that 1.0.1 has the same interface as 1.0.0 (for example). Ranged
dependencies clearly aren't appropriate for such a repo. My feeling is that
most library maintainers don't follow SemVer even if they intend to. Part of
the problem is that people don't always want to bump the major version when
they ought to because to do so has certain non-technical implications (e.g.,
"2.0" of something is often accompanied by a press release or other fanfare).
But more importantly, Mynewt is used for embedded development, and I think
most embedded developers want to know exactly which libraries they're putting
in their products. In this sense, allowing a range of repo versions does more
harm than good because it takes control away from the developer. Ranged
dependencies allow repos to unexpectedly change versions when you run `newt
upgrade`.
Finally, use of version ranges makes the job of maintaining a Mynewt repo
more difficult. A new repo version must be tested against a range of
dependency versions rather than just one.
So the first part of my proposal is to remove support for version ranges in
repo dependencies. A repo dependency must specify a single version using one
of three forms:
* Fixed version (`1.0.0`)
* Floating version (`1.6-latest`)
* Commit (`7088a7c029b5cc48efa079f5b6bb25e4a5414d24-commit`) OR
(`tagname-commit`) OR (`branchname-commit`)
BAD FEATURE 2: `VERSION.YML` FILES
To determine the version of a particular commit of a repo, newt checks out
that commit and reads the contents of a file called `version.yml`. This file
contains a single fixed version string. When a maintainer releases a new
version of a repo, they have to update `version.yml` before creating the tag.
The entire reason for this `version.yml` requirement is to support
`*-commit` dependencies. I'll give an example to illustrate what I mean:
* mynewt-core 1.6.0 DEPENDS ON mynewt-nimble 1.1.0
* mynewt-core 1.7.0 DEPENDS ON mynewt-numble 1.2.0
Now say a user doesn't want to use a versioned release of mynewt-core.
Instead, he wants his project to use a commit of mynewt-core that is somewhere
between 1.6.0 and 1.7.0 in the git history. What version of mynewt-nimble
should this particular commit depend on? What if the user depends on a
mynewt-core commit from a completely different branch? Newt answers these
questions by reading mynewt-core's `version.yml` file from the requested
commit. If the file contains "1.6.0", then core depends on nimble 1.1.0. If
it says "1.7.0", core depends on nimble 1.2.0, and so on.
So that's the rationale and the history of the `version.yml` file. In
retrospect, I think this `version.yml` idea was a mistake. Arbitrary commits
are *not* versioned releases and they should not be treated like them. When
the user specifies a `*-commit` dependency he is putting newt into a sort of
"manual override" mode. Newt should not try to figure out inter-repo
dependencies in this mode.
Another reason why `version.yml` files are bad is that they make repo
maintenance more difficult. To keep a `version.yml` file in a sane state, a
repo maintainer has to use a particular branching strategy
