[GitHub] [mynewt-nimble] turon commented on issue #785: [npl] linux porting layer unit tests fail

2020-03-26 Thread GitBox
turon commented on issue #785: [npl] linux porting layer unit tests fail
URL: https://github.com/apache/mynewt-nimble/issues/785#issuecomment-604690428
 
 
   Looks like this can be fixed by replacing main loop in 
[`test_os_sem.c`](https://github.com/apache/mynewt-nimble/blob/master/porting/npl/linux/test/test_npl_sem.c#L150):
   
   BEFORE:
   ```
  while (1)
   {
   ble_npl_eventq_run(ble_npl_eventq_dflt_get());
   }
   ```
   
   AFTER:
   ```
   while (1) {}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] vrahane commented on issue #2239: dialog_da1469x: enhance otp and serial loader tools.

2020-03-26 Thread GitBox
vrahane commented on issue #2239: dialog_da1469x: enhance otp and serial loader 
tools.
URL: https://github.com/apache/mynewt-core/pull/2239#issuecomment-604644849
 
 
   Changes look fine. I merged it since it was approved by both @utzig and 
@agross-korg


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] vrahane merged pull request #2239: dialog_da1469x: enhance otp and serial loader tools.

2020-03-26 Thread GitBox
vrahane merged pull request #2239: dialog_da1469x: enhance otp and serial 
loader tools.
URL: https://github.com/apache/mynewt-core/pull/2239
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-core] branch master updated (5ff0a42 -> bc3930d)

2020-03-26 Thread vipulrahane
This is an automated email from the ASF dual-hosted git repository.

vipulrahane pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


from 5ff0a42  Merge pull request #2251 from 
Reynevan94/STM32-blinky-tutorial-fix
 new 8d66c45  hw/bsp/dialog: enhance serial load method
 new d8876bb  otp_tool: Enhance error processing and remove key read command
 new 6d4163c  da1469x_serial: Support OpenOCD based reset script
 new bc3930d  Merge pull request #2239 from 
nkaje/otp_tool_updates_based_on_test_dev

The 9561 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 hw/bsp/dialog_da1469x-dk-pro/cfg/device.cfg| 61 +
 .../cfg/ft4232h.cfg}   | 24 
 hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py | 32 ---
 hw/bsp/dialog_da1469x-dk-pro/otp_tool.py   | 35 
 hw/bsp/dialog_da1469x-dk-pro/reset.sh  | 63 +
 hw/bsp/dialog_da1469x-dk-pro/reset_ocd.sh  | 64 ++
 6 files changed, 249 insertions(+), 30 deletions(-)
 create mode 100644 hw/bsp/dialog_da1469x-dk-pro/cfg/device.cfg
 copy hw/bsp/{nucleo-f030r8/nucleo-f030r8_download.sh => 
dialog_da1469x-dk-pro/cfg/ft4232h.cfg} (69%)
 mode change 100755 => 100644
 create mode 100755 hw/bsp/dialog_da1469x-dk-pro/reset.sh
 create mode 100755 hw/bsp/dialog_da1469x-dk-pro/reset_ocd.sh



[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #782: Remove notification for update process timeout.

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #782: Remove notification for update 
process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604629689
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #782: Remove notification for update process timeout.

2020-03-26 Thread GitBox
apache-mynewt-bot removed a comment on issue #782: Remove notification for 
update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604525690
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] turon opened a new issue #785: [npl] linux porting layer unit tests fail

2020-03-26 Thread GitBox
turon opened a new issue #785: [npl] linux porting layer unit tests fail
URL: https://github.com/apache/mynewt-nimble/issues/785
 
 
   ```
   ~/mynewt-nimble/porting/npl/linux/test$ make test
   ./test_npl_task.exe
   All tests passed
   ./test_npl_callout.exe
   All tests passed
   ./test_npl_eventq.exe
   All tests passed
   ./test_npl_sem.exe
   make: *** [Makefile:94: test] Segmentation fault
   ```
   
   It may be good to add these tests as a github action that gates pull 
requests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #784: nimble/ll: Fix build with extended advertising and without privacy

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #784: nimble/ll: Fix build with extended 
advertising and without privacy
URL: https://github.com/apache/mynewt-nimble/pull/784#issuecomment-604588304
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-core] branch master updated: STM32 blinky tutorial update

2020-03-26 Thread mlaz
This is an automated email from the ASF dual-hosted git repository.

mlaz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new f2ec1cf  STM32 blinky tutorial update
 new 5ff0a42  Merge pull request #2251 from 
Reynevan94/STM32-blinky-tutorial-fix
f2ec1cf is described below

commit f2ec1cfcfafd617de90c2ff2ac755dba05314910
Author: Krzysztof Kopyściński 
AuthorDate: Thu Mar 26 12:49:33 2020 +0100

STM32 blinky tutorial update

Because support of STM32 is located in mynewt-core, no external repos are 
necessary.
---
 docs/os/tutorials/STM32F303.rst | 51 +
 1 file changed, 6 insertions(+), 45 deletions(-)

diff --git a/docs/os/tutorials/STM32F303.rst b/docs/os/tutorials/STM32F303.rst
index b3ad7de..7ee46fa 100644
--- a/docs/os/tutorials/STM32F303.rst
+++ b/docs/os/tutorials/STM32F303.rst
@@ -49,45 +49,6 @@ re-use that project.
 
 **Note:** Don't forget to change into the ``myproj`` directory.
 
-Import External STM32F3 Library support
-~~~
-
-The STM32F303 support for Mynewt lives in an external repository. It's
-necessary to add another repository to the project. To do this, edit the
-file ``project.yml`` in the root directory of your project ``myproj``
-
-This requires two changes to this file.
-
-1. You must define the properties of the external repository that you
-   want to add
-2. You must include the repository in your project.
-
-Edit the file ``project.yml`` with your favorite editor and add the
-following repository details in the file (after the core repository).
-This gives newt the information to contact the repository and extract
-its contents. In this case, the repository is on github in the
-``runtimeco`` collection. Its name is ``mynewt-stm32f3`` and we will
-accept any version up to the latest. You can look at the contents
-`here `__.
-
-::
-
-repository.mynewt_stm32f3:
-type: github
-vers: 0-latest
-user: runtimeco
-repo: mynewt_stm32f3
-
-In the same file, add the following highlighted line to the
-``project.repositories`` variable. This tells newt to download the
-repository contents into your project.
-
-::
-
-project.repositories:
-- apache-mynewt-core
-- mynewt_stm32f3
-
 Install dependencies
 
 
@@ -121,23 +82,23 @@ the bootloader which allows you to upgrade your mynewt 
applications.
 
 $ newt target create stmf3_blinky
 $ newt target set stmf3_blinky build_profile=optimized
-$ newt target set stmf3_blinky bsp=@mynewt_stm32f3/hw/bsp/stm32f3discovery
+$ newt target set stmf3_blinky 
bsp=@apache-mynewt-core/hw/bsp/stm32f3discovery
 $ newt target set stmf3_blinky app=apps/blinky
 
 $ newt target create stmf3_boot
-$ newt target set stmf3_boot app=@apache-mynewt-core/apps/boot
-$ newt target set stmf3_boot bsp=@mynewt_stm32f3/hw/bsp/stm32f3discovery
+$ newt target set stmf3_boot app=@mcuboot/boot/mynewt
+$ newt target set stmf3_boot 
bsp=@apache-mynewt-core/hw/bsp/stm32f3discovery
 $ newt target set stmf3_boot build_profile=optimized
 
 $ newt target show
 
 targets/stmf3_blinky
 app=apps/blinky
-bsp=@mynewt_stm32f3/hw/bsp/stm32f3discovery
+bsp=@apache-mynewt-core/hw/bsp/stm32f3discovery
 build_profile=optimized
 targets/stmf3_boot
-app=apps/boot
-bsp=@mynewt_stm32f3/hw/bsp/stm32f3discovery
+app=@mcuboot/boot/mynewt
+bsp=@apache-mynewt-core/hw/bsp/stm32f3discovery
 build_profile=optimized
 
 Build the target executables



[GitHub] [mynewt-core] mlaz merged pull request #2251: STM32 blinky tutorial update

2020-03-26 Thread GitBox
mlaz merged pull request #2251: STM32 blinky tutorial update
URL: https://github.com/apache/mynewt-core/pull/2251
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #784: nimble/ll: Fix build with extended advertising and without privacy

2020-03-26 Thread GitBox
andrzej-kaczmarek opened a new pull request #784: nimble/ll: Fix build with 
extended advertising and without privacy
URL: https://github.com/apache/mynewt-nimble/pull/784
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #782: Remove notification for update process timeout.

2020-03-26 Thread GitBox
apache-mynewt-bot removed a comment on issue #782: Remove notification for 
update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604091088
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #782: Remove notification for update process timeout.

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #782: Remove notification for update 
process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604525690
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


svn commit: r38631 - in /dev/mynewt: apache-mynewt-1.8.0/rc2/ apache-nimble-1.3.0/rc2/

2020-03-26 Thread janc
Author: janc
Date: Thu Mar 26 16:11:12 2020
New Revision: 38631

Log:
Apache Mynewt 1.8.0-rc2 and Apache Mynewt NimBLE 1.3.0-rc2 release

Added:
dev/mynewt/apache-mynewt-1.8.0/rc2/
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz   (with 
props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.asc   
(with props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.sha512
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz   (with 
props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz.asc   (with 
props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz.sha512
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-1.8.0.tgz   (with 
props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-1.8.0.tgz.asc   (with 
props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-1.8.0.tgz.sha512
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-linux-1.8.0.tgz   
(with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-linux-1.8.0.tgz.asc   
(with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-linux-1.8.0.tgz.sha512
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-osx-1.8.0.tgz   
(with props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-osx-1.8.0.tgz.asc 
  (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-osx-1.8.0.tgz.sha512
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-windows-1.8.0.tgz 
  (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-windows-1.8.0.tgz.asc 
  (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newt-bin-windows-1.8.0.tgz.sha512
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-1.8.0.tgz   (with 
props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-1.8.0.tgz.asc   
(with props)
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-1.8.0.tgz.sha512

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz   
(with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz.asc
   (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz.sha512
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-osx-1.8.0.tgz  
 (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-osx-1.8.0.tgz.asc  
 (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-osx-1.8.0.tgz.sha512

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-windows-1.8.0.tgz  
 (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-windows-1.8.0.tgz.asc
   (with props)

dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-newtmgr-bin-windows-1.8.0.tgz.sha512
dev/mynewt/apache-nimble-1.3.0/rc2/
dev/mynewt/apache-nimble-1.3.0/rc2/apache-mynewt-nimble-1.3.0.tgz   (with 
props)
dev/mynewt/apache-nimble-1.3.0/rc2/apache-mynewt-nimble-1.3.0.tgz.asc   
(with props)
dev/mynewt/apache-nimble-1.3.0/rc2/apache-mynewt-nimble-1.3.0.tgz.sha512

Added: dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz
==
Binary file - no diff available.

Propchange: dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz
--
svn:mime-type = application/gzip

Added: dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.asc
==
Binary file - no diff available.

Propchange: 
dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.asc
--
svn:mime-type = application/pgp-signature

Added: dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.sha512
==
--- dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.sha512 
(added)
+++ dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-blinky-1.8.0.tgz.sha512 
Thu Mar 26 16:11:12 2020
@@ -0,0 +1,4 @@
+apache-mynewt-blinky-1.8.0.tgz: 512CFE38 26819B9D 25226788 9D82043C 9A41A666
+80E77402 C54DFC6B F891BF63 8E3353AD 9C0151EA
+91400979 E1632E10 A1B30640 947E1A09 D3EFFD34
+6D77E32D

Added: dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz
==
Binary file - no diff available.

Propchange: dev/mynewt/apache-mynewt-1.8.0/rc2/apache-mynewt-core-1.8.0.tgz
--
svn:mime-type = application/gzip

Added: 

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-604507286
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-604458440
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-core] annotated tag mynewt_1_8_0_rc2_tag updated (cb9df42 -> 1254eb8)

2020-03-26 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to annotated tag mynewt_1_8_0_rc2_tag
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


*** WARNING: tag mynewt_1_8_0_rc2_tag was modified! ***

from cb9df42  (commit)
  to 1254eb8  (tag)
 tagging cb9df4273aac1c8e627ff4df67b866ba9a22b018 (commit)
 replaces mynewt_1_8_0_rc1_tag
  by Szymon Janc
  on Thu Mar 26 16:44:34 2020 +0100

- Log -
Mynewt 1.8.0 rc2
---


No new revisions were added by this update.

Summary of changes:



[mynewt-core] annotated tag mynewt_1_8_0_tag updated (cb9df42 -> 01d26d3)

2020-03-26 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to annotated tag mynewt_1_8_0_tag
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.


*** WARNING: tag mynewt_1_8_0_tag was modified! ***

from cb9df42  (commit)
  to 01d26d3  (tag)
 tagging cb9df4273aac1c8e627ff4df67b866ba9a22b018 (commit)
 replaces mynewt_1_8_0_rc1_tag
  by Szymon Janc
  on Thu Mar 26 16:44:41 2020 +0100

- Log -
Mynewt 1.8.0
---


No new revisions were added by this update.

Summary of changes:



[mynewt-nimble] annotated tag nimble_1_3_0_rc2_tag updated (97ce3ea -> e1918c7)

2020-03-26 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to annotated tag nimble_1_3_0_rc2_tag
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git.


*** WARNING: tag nimble_1_3_0_rc2_tag was modified! ***

from 97ce3ea  (commit)
  to e1918c7  (tag)
 tagging 97ce3eacaaa79e8ed6cf71717149ced4f5328ee7 (commit)
 replaces nimble_1_3_0_rc1_tag
  by Szymon Janc
  on Thu Mar 26 15:59:33 2020 +0100

- Log -
NimBLE 1.3.0 rc2
---


No new revisions were added by this update.

Summary of changes:



[mynewt-blinky] annotated tag mynewt_1_8_0_rc2_tag updated (34e9aae -> 53e4f52)

2020-03-26 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to annotated tag mynewt_1_8_0_rc2_tag
in repository https://gitbox.apache.org/repos/asf/mynewt-blinky.git.


*** WARNING: tag mynewt_1_8_0_rc2_tag was modified! ***

from 34e9aae  (commit)
  to 53e4f52  (tag)
 tagging 34e9aae78f3ab4a4307bf99b4e25be11060aa526 (commit)
 replaces mynewt_1_8_0_rc1_tag
  by Szymon Janc
  on Thu Mar 26 15:58:42 2020 +0100

- Log -
Mynewt 1.8.0 rc2
---


No new revisions were added by this update.

Summary of changes:



[mynewt-newtmgr] annotated tag mynewt_1_8_0_rc2_tag updated (15c6a24 -> aad6a16)

2020-03-26 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to annotated tag mynewt_1_8_0_rc2_tag
in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git.


*** WARNING: tag mynewt_1_8_0_rc2_tag was modified! ***

from 15c6a24  (commit)
  to aad6a16  (tag)
 tagging 15c6a24d57d6dbdcf33646df365b2c64a12de251 (commit)
 replaces mynewt_1_8_0_rc1_tag
  by Szymon Janc
  on Thu Mar 26 15:59:01 2020 +0100

- Log -
Mynewt 1.8.0 rc2
---


No new revisions were added by this update.

Summary of changes:



[mynewt-newt] annotated tag mynewt_1_8_0_rc2_tag updated (725740e -> 63e916b)

2020-03-26 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to annotated tag mynewt_1_8_0_rc2_tag
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git.


*** WARNING: tag mynewt_1_8_0_rc2_tag was modified! ***

from 725740e  (commit)
  to 63e916b  (tag)
 tagging 725740e08825a4a15d6270cccd7ff45fdd928312 (commit)
 replaces mynewt_1_8_0_rc1_tag
  by Szymon Janc
  on Thu Mar 26 15:59:17 2020 +0100

- Log -
Mynewt 1.8.0 rc2
---


No new revisions were added by this update.

Summary of changes:



[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398626365
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1237,6 +1243,46 @@ ble_gap_adv_active_instance(uint8_t instance)
 return ble_gap_slave[instance].op == BLE_GAP_OP_S_ADV;
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_reset_state(int reason)
+{
+uint16_t conn_handle;
+
+while (1) {
+conn_handle = ble_hs_atomic_first_conn_handle();
+if (conn_handle == BLE_HS_CONN_HANDLE_NONE) {
+break;
+}
+
+ble_gap_conn_broken(conn_handle, reason);
+}
+
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+if (ble_gap_adv_active_instance(i)) {
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(i, reason, 0, 0);
+}
+}
+#else
+if (ble_gap_adv_active_instance(0)) {
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(0, reason, 0, 0);
+}
+#endif
+#endif
+
+#if NIMBLE_BLE_SCAN
 
 Review comment:
   Hi @rymanluk Do we really need `NIMBLE_BLE_CONNECT` here ? I mean given that 
we want to reset state of only master, I was thinking `NIMBLE_BLE_SCAN` should 
suffice.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-604382239
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-604458440
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398557210
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1034,6 +1034,12 @@ ble_gap_master_failed(int status)
 ble_gap_master_connect_failure(status);
 break;
 
+case BLE_GAP_OP_M_DISC:
+STATS_INC(ble_gap_stats, initiate_fail);
+ble_gap_disc_complete();
+ble_gap_master_reset_state();
 
 Review comment:
   I think it is better if we keep `#if NIMBLE_BLE_CONNECT` or `#if 
NIMBLE_BLE_SCAN` outside of `ble_gap_master_failed` function. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398555603
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1034,6 +1034,12 @@ ble_gap_master_failed(int status)
 ble_gap_master_connect_failure(status);
 break;
 
+case BLE_GAP_OP_M_DISC:
+STATS_INC(ble_gap_stats, initiate_fail);
+ble_gap_disc_complete();
+ble_gap_master_reset_state();
 
 Review comment:
   Hi @rymanluk I am getting CI failure
   
   ```
   echo 'Building target=nordic_pca10056_bttester'
   
   Building target=nordic_pca10056_bttester
   
   +newt build -q -l info nordic_pca10056_bttester
   
   2020/03/26 11:46:51.604 [INFO] Ignoring 
/home/travis/gopath/src/github.com/apache/mynewt-nimble/repos/apache-mynewt-core/hw/mcu/nordic/src/ext/nrfx/drivers/src/nrfx_power.c
 because package dictates it.
   
   +rc=0
   
   +[[ 0 -ne 0 ]]
   
   +[[ 0 -eq 127 ]]
   
   +for target in '${TARGETS}'
   
   +echo 'Building target=nordic_pca10056_ext_advertiser'
   
   Building target=nordic_pca10056_ext_advertiser
   
   +newt build -q -l info nordic_pca10056_ext_advertiser
   
   2020/03/26 11:47:43.511 [INFO] Ignoring 
/home/travis/gopath/src/github.com/apache/mynewt-nimble/repos/apache-mynewt-core/hw/mcu/nordic/src/ext/nrfx/drivers/src/nrfx_power.c
 because package dictates it.
   
   Error: nimble/host/src/ble_gap.c:1028:1: error: 'ble_gap_master_failed' 
defined but not used [-Werror=unused-function]
   
ble_gap_master_failed(int status)
   
^
   
   cc1: all warnings being treated as errors
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2251: STM32 blinky tutorial update

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #2251: STM32 blinky tutorial update
URL: https://github.com/apache/mynewt-core/pull/2251#issuecomment-604407727
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] Reynevan94 opened a new pull request #2251: STM32 blinky tutorial update

2020-03-26 Thread GitBox
Reynevan94 opened a new pull request #2251: STM32 blinky tutorial update
URL: https://github.com/apache/mynewt-core/pull/2251
 
 
   Because support of STM32 is located in mynewt-core, no external repos are 
necessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-604382239
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-603856849
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] sjanc closed issue #310: build.sh on windows is not creating binary where it should

2020-03-26 Thread GitBox
sjanc closed issue #310: build.sh on windows is not creating binary where it 
should
URL: https://github.com/apache/mynewt-newt/issues/310
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] sjanc commented on issue #310: build.sh on windows is not creating binary where it should

2020-03-26 Thread GitBox
sjanc commented on issue #310: build.sh on windows is not creating binary where 
it should
URL: https://github.com/apache/mynewt-newt/issues/310#issuecomment-604379755
 
 
   ok, the issue was not running msys2 shell as administrator (which prevented 
symlinks from working). Closing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] utzig commented on a change in pull request #389: INSTALLING.md fix

2020-03-26 Thread GitBox
utzig commented on a change in pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389#discussion_r398477438
 
 

 ##
 File path: INSTALLING.md
 ##
 @@ -25,12 +25,13 @@ following path, relative to the source directory:
 If you do not wish to run the included script, you can build newt manually 
with Go as follows (executed from the source directory):
 
 ```no-highlight
-$ mkdir "$GOPATH"/src/mynewt.apache.org
-$ cp -r * "$GOPATH"/src/mynewt.apache.org # Or untar to this path
-$ go install mynewt.apache.org/newt/newt
+$ cd "$GOPATH"/src/
+$ git clone https://github.com/apache/mynewt-newt
+$ cd mynewt-newt/newt
+$ go get
 ```
 
-This puts the newt binary in $GOPATH/bin
+This builds the newt from repository and installs it in the system.
 
 Review comment:
   > I think so, because `go help get` returns, among other things:
   > 
   > ```
   > Get downloads the packages named by the import paths, along with their
   > dependencies. It then installs the named packages, like 'go install'.
   > ```
   
   `go get` only downloads the dependencies, to build you still need to run `go 
build`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398463915
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1034,6 +1034,12 @@ ble_gap_master_failed(int status)
 ble_gap_master_connect_failure(status);
 break;
 
+case BLE_GAP_OP_M_DISC:
+STATS_INC(ble_gap_stats, initiate_fail);
+ble_gap_disc_complete();
+ble_gap_master_reset_state();
 
 Review comment:
   `#if NIMBLE_BLE_CONNECT` is applied for both functions: 
`ble_gap_master_failed` & `ble_gap_update_failed`, I will make changes 
accordinly. 
   
   > I believe we need this #if inside that function. Also #if NIMBLE_BLE_SCAN 
should be there.
   
   Yes, I will make the required changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] Reynevan94 commented on a change in pull request #389: INSTALLING.md fix

2020-03-26 Thread GitBox
Reynevan94 commented on a change in pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389#discussion_r398459968
 
 

 ##
 File path: INSTALLING.md
 ##
 @@ -25,12 +25,13 @@ following path, relative to the source directory:
 If you do not wish to run the included script, you can build newt manually 
with Go as follows (executed from the source directory):
 
 ```no-highlight
-$ mkdir "$GOPATH"/src/mynewt.apache.org
-$ cp -r * "$GOPATH"/src/mynewt.apache.org # Or untar to this path
-$ go install mynewt.apache.org/newt/newt
+$ cd "$GOPATH"/src/
+$ git clone https://github.com/apache/mynewt-newt
+$ cd mynewt-newt/newt
+$ go get
 ```
 
-This puts the newt binary in $GOPATH/bin
+This builds the newt from repository and installs it in the system.
 
 Review comment:
   I think so, because `go help get` returns, among other things:
   ```
   Get downloads the packages named by the import paths, along with their
   dependencies. It then installs the named packages, like 'go install'.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[mynewt-core] branch 1_8_0_dev updated: Fix license headers in hw/drivers/display

2020-03-26 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch 1_8_0_dev
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/1_8_0_dev by this push:
 new cb9df42  Fix license headers in hw/drivers/display
cb9df42 is described below

commit cb9df4273aac1c8e627ff4df67b866ba9a22b018
Author: Szymon Janc 
AuthorDate: Thu Mar 26 09:40:57 2020 +0100

Fix license headers in hw/drivers/display

This code is under Apache-2 license but was not developed for
Apache Software Foundation.
---
 hw/drivers/display/cfb/include/display/cfb.h  | 29 +++
 hw/drivers/display/cfb/src/cfb.c  | 25 +--
 hw/drivers/display/cfb/src/cfb_fonts.c| 28 --
 hw/drivers/display/include/display/display.h  | 29 +++
 hw/drivers/display/ssd1673/src/ssd1673.c  | 25 +--
 hw/drivers/display/ssd1673/src/ssd1673_regs.h | 25 +--
 6 files changed, 67 insertions(+), 94 deletions(-)

diff --git a/hw/drivers/display/cfb/include/display/cfb.h 
b/hw/drivers/display/cfb/include/display/cfb.h
index 5a0305d..ea85380 100644
--- a/hw/drivers/display/cfb/include/display/cfb.h
+++ b/hw/drivers/display/cfb/include/display/cfb.h
@@ -1,23 +1,18 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *  http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
  * Copyright (c) 2018 PHYTEC Messtechnik GmbH
  *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
  */
 
 /**
diff --git a/hw/drivers/display/cfb/src/cfb.c b/hw/drivers/display/cfb/src/cfb.c
index 273fd1c..15133b2 100644
--- a/hw/drivers/display/cfb/src/cfb.c
+++ b/hw/drivers/display/cfb/src/cfb.c
@@ -1,22 +1,17 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
+ * Copyright (c) 2018 PHYTEC Messtechnik GmbH
  *
- *  http://www.apache.org/licenses/LICENSE-2.0
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
+ *http://www.apache.org/licenses/LICENSE-2.0
  *
- * Copyright (c) 2018 PHYTEC Messtechnik GmbH
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  *
  */
 
diff --git a/hw/drivers/display/cfb/src/cfb_fonts.c 
b/hw/drivers/display/cfb/src/cfb_fonts.c
index 79778f2..6a2628a 100644
--- a/hw/drivers/display/cfb/src/cfb_fonts.c
+++ b/hw/drivers/display/cfb/src/cfb_fonts.c
@@ -1,23 +1,21 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF 

[GitHub] [mynewt-core] sjanc merged pull request #2250: Fix license headers in hw/drivers/display

2020-03-26 Thread GitBox
sjanc merged pull request #2250: Fix license headers in hw/drivers/display
URL: https://github.com/apache/mynewt-core/pull/2250
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] sjanc commented on a change in pull request #389: INSTALLING.md fix

2020-03-26 Thread GitBox
sjanc commented on a change in pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389#discussion_r398446722
 
 

 ##
 File path: INSTALLING.md
 ##
 @@ -25,12 +25,13 @@ following path, relative to the source directory:
 If you do not wish to run the included script, you can build newt manually 
with Go as follows (executed from the source directory):
 
 ```no-highlight
-$ mkdir "$GOPATH"/src/mynewt.apache.org
-$ cp -r * "$GOPATH"/src/mynewt.apache.org # Or untar to this path
-$ go install mynewt.apache.org/newt/newt
+$ cd "$GOPATH"/src/
+$ git clone https://github.com/apache/mynewt-newt
+$ cd mynewt-newt/newt
+$ go get
 ```
 
-This puts the newt binary in $GOPATH/bin
+This builds the newt from repository and installs it in the system.
 
 Review comment:
   Does "go get" really do that?  For me it only downloads dependencies (as 
stated in go help).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] sjanc commented on issue #390: Error during execution of build.sh

2020-03-26 Thread GitBox
sjanc commented on issue #390: Error during execution of build.sh
URL: https://github.com/apache/mynewt-newt/issues/390#issuecomment-604331683
 
 
   I think we should invoke this as
   #!/bin/sh -l
   so that user login environment is used.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2250: Fix license headers in hw/drivers/display

2020-03-26 Thread GitBox
apache-mynewt-bot commented on issue #2250: Fix license headers in 
hw/drivers/display
URL: https://github.com/apache/mynewt-core/pull/2250#issuecomment-604327320
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] Reynevan94 opened a new issue #390: Error during execution of build.sh

2020-03-26 Thread GitBox
Reynevan94 opened a new issue #390: Error during execution of build.sh
URL: https://github.com/apache/mynewt-newt/issues/390
 
 
   Running shell script causes error
   ```
   ./build.sh: 30: ./build.sh: go: not found
   * Error: could not extract go version (version string: )
   ```
   basically it cannot extract version number from `go version` command 
although this returns normal output, i.e.:
   ```
   go version go1.14.1 linux/amd64
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-newt] Reynevan94 opened a new pull request #389: INSTALLING.md fix

2020-03-26 Thread GitBox
Reynevan94 opened a new pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389
 
 
   - corrected requiered version of Go
   - second method of installation made easier


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] sjanc opened a new pull request #2250: Fix license headers in hw/drivers/display

2020-03-26 Thread GitBox
sjanc opened a new pull request #2250: Fix license headers in hw/drivers/display
URL: https://github.com/apache/mynewt-core/pull/2250
 
 
   This code is under Apache-2 license but was not developed for
   Apache Software Foundation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398392913
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1034,6 +1034,12 @@ ble_gap_master_failed(int status)
 ble_gap_master_connect_failure(status);
 break;
 
+case BLE_GAP_OP_M_DISC:
+STATS_INC(ble_gap_stats, initiate_fail);
+ble_gap_disc_complete();
+ble_gap_master_reset_state();
 
 Review comment:
   > could you double check if ble_gap_master_reset_state(); we need only for 
BLE_GAP_OP_M_DISC: and not for `BLE_GAP_OP_M_CONN' ?
   
   For `BLE_GAP_OP_M_CONN`, `ble_gap_master_connect_failure` --> 
`ble_gap_master_extract_state` --> calls `ble_gap_master_reset_state`. So we 
need it only for `BLE_GAP_OP_M_DISC`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398384871
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1237,6 +1243,46 @@ ble_gap_adv_active_instance(uint8_t instance)
 return ble_gap_slave[instance].op == BLE_GAP_OP_S_ADV;
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_reset_state(int reason)
+{
+uint16_t conn_handle;
+
+while (1) {
+conn_handle = ble_hs_atomic_first_conn_handle();
+if (conn_handle == BLE_HS_CONN_HANDLE_NONE) {
+break;
+}
+
+ble_gap_conn_broken(conn_handle, reason);
+}
+
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+if (ble_gap_adv_active_instance(i)) {
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(i, reason, 0, 0);
+}
+}
+#else
+if (ble_gap_adv_active_instance(0)) {
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(0, reason, 0, 0);
+}
+#endif
+#endif
+
+#if NIMBLE_BLE_SCAN
 
 Review comment:
   #if( NIMBLE_BLE_SCAN || NIMBLE_BLE_CONNECT) ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398386305
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1034,6 +1034,12 @@ ble_gap_master_failed(int status)
 ble_gap_master_connect_failure(status);
 break;
 
+case BLE_GAP_OP_M_DISC:
+STATS_INC(ble_gap_stats, initiate_fail);
+ble_gap_disc_complete();
+ble_gap_master_reset_state();
 
 Review comment:
   BTW - just noticed that above `ble_gap_master_failed(int status)` there is 
#if NIMBLE_BLE_CONNECT
   
   I believe we need this #if inside that function. Also #if NIMBLE_BLE_SCAN 
should be there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

2020-03-26 Thread GitBox
rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r398385475
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -1034,6 +1034,12 @@ ble_gap_master_failed(int status)
 ble_gap_master_connect_failure(status);
 break;
 
+case BLE_GAP_OP_M_DISC:
+STATS_INC(ble_gap_stats, initiate_fail);
+ble_gap_disc_complete();
+ble_gap_master_reset_state();
 
 Review comment:
   could you double check if ` ble_gap_master_reset_state();` we need only for 
`BLE_GAP_OP_M_DISC:` and not for `BLE_GAP_OP_M_CONN' ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] sjanc commented on issue #2246: newt upgrade failed - Error: usage: git rev-list [OPTION] ... [ -- paths... ]

2020-03-26 Thread GitBox
sjanc commented on issue #2246: newt upgrade failed - Error: usage: git 
rev-list [OPTION] ... [ -- paths... ]
URL: https://github.com/apache/mynewt-core/issues/2246#issuecomment-604281767
 
 
   Great!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] sjanc closed issue #2246: newt upgrade failed - Error: usage: git rev-list [OPTION] ... [ -- paths... ]

2020-03-26 Thread GitBox
sjanc closed issue #2246: newt upgrade failed - Error: usage: git rev-list 
[OPTION] ... [ -- paths... ]
URL: https://github.com/apache/mynewt-core/issues/2246
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] w277277w edited a comment on issue #2246: newt upgrade failed - Error: usage: git rev-list [OPTION] ... [ -- paths... ]

2020-03-26 Thread GitBox
w277277w edited a comment on issue #2246: newt upgrade failed - Error: usage: 
git rev-list [OPTION] ... [ -- paths... ]
URL: https://github.com/apache/mynewt-core/issues/2246#issuecomment-604255886
 
 
   @sjanc Thank you for your mind. The issue was solved


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [mynewt-core] w277277w commented on issue #2246: newt upgrade failed - Error: usage: git rev-list [OPTION] ... [ -- paths... ]

2020-03-26 Thread GitBox
w277277w commented on issue #2246: newt upgrade failed - Error: usage: git 
rev-list [OPTION] ... [ -- paths... ]
URL: https://github.com/apache/mynewt-core/issues/2246#issuecomment-604255886
 
 
   @sjanc Thank you for your mind. The issue was sloved


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services