[GitHub] [mynewt-nimble] prasad-alatkar commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
prasad-alatkar commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-607031816 @h2zero That is a valid point, will update if I find anything. Maybe @rymanluk can explain it

[GitHub] [mynewt-core] benmccrea opened a new pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
benmccrea opened a new pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257 This PR adds a new optional field, id/serial_mfg to be used for alternate serial numbers on devices during the

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606996564 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] benmccrea commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
benmccrea commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256#issuecomment-606997984 Closing in favor of 2257 This

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
apache-mynewt-bot removed a comment on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606996564 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606999280 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] caspermeijn opened a new pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
caspermeijn opened a new pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255 This adds a driver for the SGM4056 driver. The first commit adds the base driver, second commit adds charge control integration to the base driver.

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-606501796 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2224: add functionality to allow low power operation for STM32L1xx

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2224: add functionality to allow low power operation for STM32L1xx URL: https://github.com/apache/mynewt-core/pull/2224#issuecomment-606555366 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2224: add functionality to allow low power operation for STM32L1xx

2020-03-31 Thread GitBox
apache-mynewt-bot removed a comment on issue #2224: add functionality to allow low power operation for STM32L1xx URL: https://github.com/apache/mynewt-core/pull/2224#issuecomment-595362454 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
kasjer commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r400836974 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020

[GitHub] [mynewt-nimble] h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-03-31 Thread GitBox
h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-606723283 I found this as well, currently testing a fix in my own

[GitHub] [mynewt-nimble] joonazan opened a new issue #789: How to use ble_gap_connect?

2020-03-31 Thread GitBox
joonazan opened a new issue #789: How to use ble_gap_connect? URL: https://github.com/apache/mynewt-nimble/issues/789 I am using NimBLE with esp-idf. I would like to set the connection interval but I can't figure out how. ble_gap_connect lets you set the interval but it seems that

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 MCUs URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-606714969 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-03-31 Thread GitBox
apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver for STM32 MCUs URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-605108684 ## Style check summary ### Our coding style is

[GitHub] [mynewt-nimble] prasad-alatkar opened a new pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
prasad-alatkar opened a new pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790 Issue reference: #788 Description: In cases where CCCDs are exceeding MYNEWT_VAL(BLE_STORE_MAX_CCCDS)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-606821185 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401104932 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401104381 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401102369 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401104807 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401102875 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020

[GitHub] [mynewt-core] mlaz commented on issue #2254: [RFC] docs/os/bsp: Add board support section

2020-03-31 Thread GitBox
mlaz commented on issue #2254: [RFC] docs/os/bsp: Add board support section URL: https://github.com/apache/mynewt-core/pull/2254#issuecomment-606784118 Ok, I changed the title of this PR to [RFC] since this is a structural change to doc. Anyway I agree with it and I think we should

[GitHub] [mynewt-nimble] h2zero commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
h2zero commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-606926563 Glad you built a proper fix and hope it gets merged. I still question why we store cccd data

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256#issuecomment-606987980 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256#issuecomment-606987859 ## RAT Report (2020-04-01 02:20:28) ## New files with unknown licenses

[GitHub] [mynewt-core] benmccrea closed pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
benmccrea closed pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256 This is an automated message from the Apache Git

[GitHub] [mynewt-core] benmccrea opened a new pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
benmccrea opened a new pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256 This PR adds a new optional field, `id/serial_mfg` to be used for alternate serial numbers on devices during the