[GitHub] [mynewt-nimble] SumeetSingh19 commented on a diff in pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

SumeetSingh19 commented on code in PR #1426: URL: https://github.com/apache/mynewt-nimble/pull/1426#discussion_r1149121770 ## nimble/host/src/ble_gattc.c: ## @@ -4212,6 +4223,61 @@ ble_gatts_notify_custom(uint16_t conn_handle, uint16_t chr_val_handle, return rc; } +int

[GitHub] [mynewt-nimble] SumeetSingh19 commented on a diff in pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

SumeetSingh19 commented on code in PR #1426: URL: https://github.com/apache/mynewt-nimble/pull/1426#discussion_r1149006790 ## nimble/host/src/ble_gattc.c: ## @@ -4212,6 +4223,61 @@ ble_gatts_notify_custom(uint16_t conn_handle, uint16_t chr_val_handle, return rc; } +int

[GitHub] [mynewt-nimble] SumeetSingh19 commented on a diff in pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

SumeetSingh19 commented on code in PR #1426: URL: https://github.com/apache/mynewt-nimble/pull/1426#discussion_r1149123945 ## nimble/host/src/ble_att_clt.c: ## @@ -907,6 +907,59 @@ ble_att_clt_tx_notify(uint16_t conn_handle, uint16_t handle, return rc; }

[GitHub] [mynewt-nimble] SumeetSingh19 commented on a diff in pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

SumeetSingh19 commented on code in PR #1426: URL: https://github.com/apache/mynewt-nimble/pull/1426#discussion_r1149125076 ## nimble/host/src/ble_att_clt.c: ## @@ -907,6 +907,59 @@ ble_att_clt_tx_notify(uint16_t conn_handle, uint16_t handle, return rc; }

[GitHub] [mynewt-nimble] SumeetSingh19 commented on a diff in pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

SumeetSingh19 commented on code in PR #1426: URL: https://github.com/apache/mynewt-nimble/pull/1426#discussion_r114984 ## nimble/host/include/host/ble_gatt.h: ## @@ -473,6 +473,23 @@ int ble_gattc_write_reliable(uint16_t conn_handle, int ble_gatts_notify_custom(uint16_t

[GitHub] [mynewt-nimble] SumeetSingh19 commented on a diff in pull request #1426: NimBLE/Host: Feature Multi Handle Value Notification

SumeetSingh19 commented on code in PR #1426: URL: https://github.com/apache/mynewt-nimble/pull/1426#discussion_r1149000536 ## nimble/include/nimble/nimble_opt_auto.h: ## @@ -105,6 +105,10 @@ extern "C" { #define NIMBLE_BLE_ATT_CLT_INDICATE \

[GitHub] [mynewt-newtmgr] Frank-Buss opened a new pull request, #198: use the timeout from the command line

Frank-Buss opened a new pull request, #198: URL: https://github.com/apache/mynewt-newtmgr/pull/198 This patch changes the hardcoded 3 seconds timeout to the timeout which is actually specified at the command line, or the default 10 seconds if nothing is specified. The 3 seconds was not