benmccrea opened a new pull request, #3095:
URL: https://github.com/apache/mynewt-core/pull/3095
In the default irq handler, hal_watchdog_tickle() was called before doing a
core dump but on Dialog da1469x this causes the reset reason to be lost, and
reboot log was recording the reset
benmccrea commented on PR #3095:
URL: https://github.com/apache/mynewt-core/pull/3095#issuecomment-1764937295
Closing (accidentally opened)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
benmccrea closed pull request #3095: kernel/os: Fix issue that causes WDOG
reset reason to be lost
URL: https://github.com/apache/mynewt-core/pull/3095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
benmccrea commented on PR #3094:
URL: https://github.com/apache/mynewt-core/pull/3094#issuecomment-1765387712
@andrzej-kaczmarek Thanks, I agree with you. We'll find a different way. We
can use os_coredump_cb as you suggest, or we might be able to modify how
watchdog reboot reason is
benmccrea closed pull request #3094: kernel/os: Fix issue that causes WDOG
reset reason to be lost
URL: https://github.com/apache/mynewt-core/pull/3094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360266772
##
nimble/host/src/ble_hs.c:
##
@@ -675,6 +699,28 @@ ble_hs_rx_data(struct os_mbuf *om, void *arg)
return 0;
}
+static int
+ble_hs_rx_iso(struct os_mbuf
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360270221
##
nimble/host/src/ble_hs_startup.c:
##
@@ -230,6 +273,29 @@ ble_hs_startup_le_set_evmask_tx(void)
mask |= 0x000ff800;
}
+if
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360272365
##
nimble/syscfg.yml:
##
@@ -102,6 +102,10 @@ syscfg.defs:
value: 0
restrictions:
- 'BLE_ISO if 1'
+BLE_ISO_LOOPBACK:
Review
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360274902
##
nimble/transport/socket/src/ble_hci_socket.c:
##
@@ -173,6 +178,48 @@ static int s_ble_hci_device =
MYNEWT_VAL(BLE_SOCK_LINUX_DEV);
static int
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360269757
##
nimble/host/src/ble_hs_startup.c:
##
@@ -230,6 +273,29 @@ ble_hs_startup_le_set_evmask_tx(void)
mask |= 0x000ff800;
}
+if
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360278587
##
nimble/host/syscfg.yml:
##
@@ -497,10 +507,21 @@ syscfg.defs:
description: 'Minimum level for the BLE EATT log.'
value: 1
+
KKopyscinski commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360276234
##
nimble/controller/src/ble_ll_hci.c:
##
@@ -1276,9 +1276,6 @@ ble_ll_hci_le_cmd_proc(const uint8_t *cmdbuf, uint8_t
len, uint16_t ocf,
break;
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360287108
##
nimble/host/src/ble_iso.c:
##
@@ -0,0 +1,1181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
KKopyscinski commented on code in PR #1594:
URL: https://github.com/apache/mynewt-nimble/pull/1594#discussion_r1360436433
##
nimble/host/src/ble_gattc.c:
##
@@ -4413,6 +4413,109 @@ ble_gatts_notify(uint16_t conn_handle, uint16_t
chr_val_handle)
return rc;
}
+int
rymanluk commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360299940
##
nimble/controller/src/ble_ll_hci.c:
##
@@ -1276,9 +1276,6 @@ ble_ll_hci_le_cmd_proc(const uint8_t *cmdbuf, uint8_t
len, uint16_t ocf,
break;
KKopyscinski commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360306091
##
nimble/controller/src/ble_ll_hci.c:
##
@@ -1276,9 +1276,6 @@ ble_ll_hci_le_cmd_proc(const uint8_t *cmdbuf, uint8_t
len, uint16_t ocf,
break;
rymanluk commented on code in PR #1594:
URL: https://github.com/apache/mynewt-nimble/pull/1594#discussion_r1360309125
##
nimble/host/src/ble_att_clt.c:
##
@@ -986,3 +986,33 @@ ble_att_clt_rx_indicate(uint16_t conn_handle, uint16_t
cid, struct os_mbuf **rxo
}
#endif
+
rymanluk commented on code in PR #1594:
URL: https://github.com/apache/mynewt-nimble/pull/1594#discussion_r1360313154
##
nimble/host/src/ble_gattc.c:
##
@@ -4413,6 +4413,109 @@ ble_gatts_notify(uint16_t conn_handle, uint16_t
chr_val_handle)
return rc;
}
+int
KKopyscinski commented on code in PR #1622:
URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1360311979
##
nimble/host/syscfg.yml:
##
@@ -497,10 +507,21 @@ syscfg.defs:
description: 'Minimum level for the BLE EATT log.'
value: 1
+
rymanluk commented on code in PR #1594:
URL: https://github.com/apache/mynewt-nimble/pull/1594#discussion_r1360315774
##
apps/btshell/src/cmd.c:
##
@@ -4417,6 +4454,27 @@ static const struct shell_cmd btshell_commands[] = {
.sc_cmd_func = cmd_gatt_write,
#if
andrzej-kaczmarek commented on PR #3094:
URL: https://github.com/apache/mynewt-core/pull/3094#issuecomment-1764063852
If you replace `tickle` with `disable` and leave `disable` not implemented
for all platforms but dialog, it will possibly break those platforms as in
mentioned issue. Also
rymanluk commented on code in PR #1594:
URL: https://github.com/apache/mynewt-nimble/pull/1594#discussion_r1360309125
##
nimble/host/src/ble_att_clt.c:
##
@@ -986,3 +986,33 @@ ble_att_clt_rx_indicate(uint16_t conn_handle, uint16_t
cid, struct os_mbuf **rxo
}
#endif
+
rymanluk commented on code in PR #1594:
URL: https://github.com/apache/mynewt-nimble/pull/1594#discussion_r1360315440
##
apps/btshell/src/cmd.c:
##
@@ -4417,6 +4454,27 @@ static const struct shell_cmd btshell_commands[] = {
.sc_cmd_func = cmd_gatt_write,
#if
KKopyscinski opened a new pull request, #1641:
URL: https://github.com/apache/mynewt-nimble/pull/1641
This patch makes MYNEWT_VAL flags consistent: BLE_LL_CFG_FEAT_LL_ISO defines
same functionality as BLE_LL_ISO, and the latter shall be used.
Removed duplicated case in
24 matches
Mail list logo
